innodb_log_block_size patch converted some C arrays to VLAs | compiling fails on solaris 11.2 with oracle sun studio compiler 12.4

Bug #1394357 reported by Filip Francis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
High
Laurynas Biveinis
5.1
Won't Fix
Undecided
Unassigned
5.5
Fix Released
High
Laurynas Biveinis
5.6
Fix Released
High
Laurynas Biveinis

Bug Description

Hi ,

getting following error when compiling with Oracle sun studio compiler 12.4
"/Compiler/Src/mysql/percona-server-5.6.21-70.0/storage/innobase/log/log0log.cc", line 228: Error: An integer constant expression is required within the array subscript operator.
1 Error(s) detected.
gmake[2]: *** [storage/innobase/CMakeFiles/innobase.dir/log/log0log.cc.o] Error 2

regards
Filip

Related branches

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

The innodb_log_block_size patch converted byte tmp_buf[OS_FILE_LOG_BLOCK_SIZE]; to a VLA, which is non-standard C++.

tags: added: low-hanging-fruit xtradb
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Upstream MySQL 5.5.41 / 5.6.22 merge makes the VLA warning fatal for debug builds.

summary: - Compiling Percona server 5.6 on solaris 11.2 with oracle sun studio
- compiler 12.4
+ innodb_log_block_size patch converted some C arrays to VLAs | compiling
+ fails on solaris 11.2 with oracle sun studio compiler 12.4
Revision history for this message
Alexey Kopytov (akopytov) wrote :

MariaDB has a better solution to the problem than the one being proposed in the linked branches, see for example https://github.com/MariaDB/server/commit/4b3cf4aa26833206c650be2e40caebf6191d5302

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Yes, thank you

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-849

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.