may frequently try to upload reports when server responds with 400

Bug #1392412 reported by Brian Murray
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
whoopsie (Ubuntu)
Fix Released
Medium
Brian Murray

Bug Description

parse_and_upload_report will return success = True on a 400 response from the server, however if for some reason the report is not marked as handled (mark_handled) then because there is no .uploaded file whoopsie will continually try to upload the .crash file.

from src/whoopsie.c:

        } else if (online_state && parse_and_upload_report (crash_file)) {
            if (!mark_handled (crash_file))
                log_msg ("Unable to mark report as seen (%s)\n", crash_file);

        }

Given that every crash report is not precious, we should just remove the crash_file if mark_handled fails.

summary: - may constantly try upload reports where server responds with 400
+ may constantly try to upload reports where server responds with 400
summary: - may constantly try to upload reports where server responds with 400
+ may constantly try to upload reports when server responds with 400
Revision history for this message
Brian Murray (brian-murray) wrote : Re: may constantly try to upload reports when server responds with 400

Evan points out that it should only try to upload the crash report every 2 hours so it is not *that* bad.

description: updated
Changed in whoopsie (Ubuntu):
importance: Undecided → Medium
summary: - may constantly try to upload reports when server responds with 400
+ may frequently try to upload reports when server responds with 400
description: updated
Changed in whoopsie (Ubuntu):
assignee: nobody → Brian Murray (brian-murray)
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package whoopsie - 0.2.43

---------------
whoopsie (0.2.43) vivid; urgency=medium

  * Remove .crash file if we are unable to create a .uploaded file for it
    to prevent trying to upload the same crash file multiple times.
    (LP: #1392412)
  * Avoid buffer overflow when parsing reports. Thanks to John-Mark Bell for
    the patch. (LP: #1397340)
 -- Brian Murray <email address hidden> Wed, 17 Dec 2014 16:17:33 -0800

Changed in whoopsie (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.