Ubuntu RTM
ubuntu-ui-toolkit package

theme not found when using a user-defined theme

Bug #1389792 reported by Jamie Strandboge
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Zsombor Egri
Vivid
New
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu RTM)
Fix Released
High
Zsombor Egri

Bug Description

This bugs makes it so that developers cannot update the theming, which can be pretty important for some people and also important for working around color scheme issues in the theming (I've filed other bugs on this).

Attached is a very simple application that tries to define the Foo theme which is derived from the SuruDark theme.

$ tar -zxvf ./theme-test.tar.gz
./theme-test/
./theme-test/themes/
./theme-test/themes/Foo/
./theme-test/themes/Foo/parent_theme
./theme-test/themes/Foo/Palette.qml
./theme-test/themes/Foo/MainViewStyle.qml
./theme-test/main.qml

$ cd theme-test/

$ qmlscene ./main.qml
"Theme not found: " "themes.Foo"
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/MainView.qml:330:9: QML AppHeader: Warning: Style PageHeadStyle.qml not found in theme themes.Foo
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/MainView.qml:202:5: QML StyledItem: Warning: Style MainViewStyle.qml not found in theme themes.Foo
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml:70:5: QML Binding: Binding loop detected for property "target"

See original description
Tags: ota-1

Related branches

lp:~zsombi/ubuntu-ui-toolkit/app-theming
Tim Peeters: Approve (quick look)
Cris Dywan: Approve
Diff: 529 lines (+370/-21)
16 files modified
examples/customtheme/customtheme.apparmor (+8/-0)
examples/customtheme/customtheme.desktop (+8/-0)
examples/customtheme/customtheme.qmlproject (+59/-0)
examples/customtheme/main.qml (+103/-0)
examples/customtheme/manifest.json (+15/-0)
examples/customtheme/theme/Palette.qml (+24/-0)
examples/customtheme/theme/parent_theme (+1/-0)
modules/Ubuntu/Components/MainView.qml (+16/-0)
modules/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml (+0/-17)
modules/Ubuntu/Components/plugin/uctheme.cpp (+4/-2)
tests/unit_x11/tst_components/tst_theming.qml (+60/-0)
tests/unit_x11/tst_theme_engine/AppTheme/Palette.qml (+24/-0)
tests/unit_x11/tst_theme_engine/AppTheme/parent_theme (+1/-0)
tests/unit_x11/tst_theme_engine/TestApp.qml (+29/-0)
tests/unit_x11/tst_theme_engine/tst_theme_engine.pro (+3/-1)
tests/unit_x11/tst_theme_engine/tst_theme_enginetest.cpp (+15/-1)
lp:~zsombi/ubuntu-ui-toolkit/app-theming-to-staging
PS Jenkins bot: Approve (continuous-integration)
Cris Dywan: Approve
Diff: 518 lines (+368/-20)
16 files modified
examples/customtheme/customtheme.apparmor (+8/-0)
examples/customtheme/customtheme.desktop (+8/-0)
examples/customtheme/customtheme.qmlproject (+59/-0)
examples/customtheme/main.qml (+103/-0)
examples/customtheme/manifest.json (+15/-0)
examples/customtheme/theme/Palette.qml (+24/-0)
examples/customtheme/theme/parent_theme (+1/-0)
modules/Ubuntu/Components/MainView.qml (+16/-0)
modules/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml (+0/-17)
modules/Ubuntu/Components/plugin/uctheme.cpp (+3/-1)
tests/unit_x11/tst_components/tst_theming.qml (+60/-0)
tests/unit_x11/tst_theme_engine/AppTheme/Palette.qml (+24/-0)
tests/unit_x11/tst_theme_engine/AppTheme/parent_theme (+1/-0)
tests/unit_x11/tst_theme_engine/TestApp.qml (+29/-0)
tests/unit_x11/tst_theme_engine/tst_theme_engine.pro (+3/-1)
tests/unit_x11/tst_theme_engine/tst_theme_enginetest.cpp (+14/-1)
lp:ubuntu/vivid-proposed/ubuntu-ui-toolkit
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Zsombor Egri (zsombi)
status: New → Confirmed
Changed in ubuntu-ui-toolkit:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Zsombor Egri (zsombi)
Jamie Strandboge (jdstrand)
description: updated
description: updated
Jamie Strandboge (jdstrand)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → High
tags: added: ota-1
Jamie Strandboge (jdstrand)
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: New → Confirmed
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Triaged → Confirmed
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
importance: Undecided → High
assignee: nobody → Zsombor Egri (zsombi)
Zoltan Balogh (bzoltan)
no longer affects: ubuntu-ui-toolkit (Ubuntu)
Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Zsombor Egri (zsombi)
importance: Undecided → High
status: New → Confirmed
Zoltan Balogh (bzoltan)
no longer affects: ubuntu-ui-toolkit
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: Confirmed → In Progress
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Zsombor Egri (zsombi) wrote :

Jamie, for now the application can set the theme in the MainView, in Component.Completed. See examples/customtheme application from the branch attached to the bug.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1364+15.04.20141209-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1364+15.04.20141209-0ubuntu1) vivid; urgency=medium

  [ Zsombor Egri ]
  * Theming fixes: application theming, binding loop fix, auto-theming
    moved into MainView and it is applicable only on Ambiance and
    SuruDark, SuruGradient is no longer auto-themed.
    Fixes: LP: #1213043, LP: #1277647, LP: #1330510, LP: #1356779,
           LP: #1389792.
  * ServiceProperties component to Ubuntu.Components 1.1.
    Fixes: LP: #1391877.
  * New ListItem component base. Support for leading/trailing actions.
    Exported in Ubuntu.Components 1.2 UNSTABLE release.
    Fixes: LP: #1097728, LP: #1372592, LP: #1383870.
  * removing failing ServiceProperties and app-theming branches
  * Application theming ant other theming related binding loop fixes
  * ServiceProperties DBus property watcher

  [ Christian Dywan ]
  * Do the default theme check properly: for non-debug and without
    build errors.
  * Don't activate the control in ListItem.Standard implicitly.
    Fixes: LP: #1372563.
  * Improve AutoPilot caret dragging test cases.
  * Use new qt_gl_set_global_share_context setter with Qt 5.4.
    Fixes: LP: #1397979.
  * Add sortCaseSensitivity to the SortFilterModel example.
    Fixes: LP: #1391034.
  * Change offending links into bold font. Fixes: LP: #1395011.

  [ Daniel d'Andrada ]
  * This is needed by unity8 for the "shell rotation" feature (ie
    shell does all the rotation work instead of apps rotating
    themselves). unity8's dialogs (like the power dialog when you
    long press the power button) should follow its parent item
    rotation and size, as one would expect, and not be sneakily
    reparented to the scene root item, in which case the shell
    UI would be rotated but its dialog would not.
    Related bug LP: #1394511. Fixes: LP: #1394511.

  [ Tim Peeters ]
  * Remove the old header separator style. Fixes: LP: #1372590.

  [ Loïc Molinari ]
  * Made the UCAlarmPrivate destructor private.

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Tue, 09 Dec 2014 11:47:33 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: New → Fix Released
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.