Mir

Missing cursors for diagonal resize top-left corner and bottom-left corner

Bug #1388987 reported by William Hua
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mir
Triaged
Medium
Unassigned
mir (Ubuntu)
Triaged
Medium
Unassigned

Bug Description

In include/common/mir_toolkit/cursors.h, there are cursor names mir_diagonal_resize_bottom_to_top_cursor_name and mir_diagonal_resize_top_to_bottom_cursor_name, but these can't be used for the top-left and bottom-left cursors since they aren't diagonally symmetrical. We need four different names for the four different possible directions.

See original description
William Hua (attente)
description: updated
Revision history for this message
Robert Carr (robertcarr) wrote :

Seems correct! I hadn't considered cursor themes where resize top left wasn't the same as resize bottom right. Qt doesn't seem to support this either, though GDK does, so why not! Thanks.

Changed in mir:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Robert Carr (robertcarr)
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Currently low priority but if you can give us a better idea on how this is impacting your progress, we can see if it can be worked on sooner.

Daniel van Vugt (vanvugt)
tags: added: clientapi cursor
Changed in mir:
status: Confirmed → Triaged
Revision history for this message
William Hua (attente) wrote :

Thanks, we need it for the reason Robert mentioned (the GDK Mir backend). It is low priority though, I'm just using reusing the right corner cursors for the left corners, but they do look a bit weird.

Daniel van Vugt (vanvugt)
Changed in mir:
assignee: Robert Carr (robertcarr) → nobody
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Qt has a bunch of cursors that Mir is missing too. See the FIXMEs:

https://code.launchpad.net/~vanvugt/qtubuntu/fix-cursor/+merge/306597
http://doc.qt.io/qt-5/qcursor.html#a-note-for-x11-users

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Mir is missing a bunch of stock cursors:

31 + mShapeToCursorName[Qt::UpArrowCursor] = mir_default_cursor_name; // FIXME
37 + // FIXME: mir_toolkit/cursors.h contains typos which make these unclear:
38 + mShapeToCursorName[Qt::SizeBDiagCursor] = mir_default_cursor_name; // FIXME
39 + mShapeToCursorName[Qt::SizeFDiagCursor] = mir_default_cursor_name; // FIXME
45 + mShapeToCursorName[Qt::ForbiddenCursor] = mir_default_cursor_name; // FIXME
46 + mShapeToCursorName[Qt::WhatsThisCursor] = mir_default_cursor_name; // FIXME
47 + mShapeToCursorName[Qt::BusyCursor] = mir_default_cursor_name; // FIXME
50 + mShapeToCursorName[Qt::DragCopyCursor] = mir_default_cursor_name; // FIXME
51 + mShapeToCursorName[Qt::DragMoveCursor] = mir_default_cursor_name; // FIXME
52 + mShapeToCursorName[Qt::DragLinkCursor] = mir_default_cursor_name; // FIXME

summary: - Missing cursors for diagonal resize top-left corner and bottom-left
- corner
+ Missing is missing a bunch of stock named cursors
Changed in mir:
importance: Low → Medium
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Re: Default cursor theme contains wrong images for mir_diagonal_resize_top_to_bottom_cursor_name and mir_diagonal_resize_bottom_to_top_cursor_name

Oh I see. Confusion came from Will incorrectly identifying the problem here.

The problem here is that those two faulty cursors should be two-way diagonal arrows. Because there are only two, that matches the documentation describing them better, and that's also what QtUbuntu expects.

There are also a bunch of missing cursors, now logged in bug 1632614.

summary: - Missing is missing a bunch of stock named cursors
+ Default cursor theme contains wrong images for
+ mir_diagonal_resize_top_to_bottom_cursor_name and
+ mir_diagonal_resize_bottom_to_top_cursor_name
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Sorry, Will was right. Since X doesn't actually have those cursors I describe (they are from MS Windows) we should add the two missing ones Will suggests.

summary: - Default cursor theme contains wrong images for
- mir_diagonal_resize_top_to_bottom_cursor_name and
- mir_diagonal_resize_bottom_to_top_cursor_name
+ Missing cursors for diagonal resize top-left corner and bottom-left
+ corner
Gerry Boland (gerboland)
Changed in mir:
milestone: none → 0.28.0
Revision history for this message
Michał Sawicz (saviq) wrote :

Syncing task from Mir.

Changed in mir (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.