Ubuntu
unity-scopes-shell package

Canned queries to favorited scopes don't preserve search query string

Bug #1386698 reported by Facundo Batista
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Unassigned
Canonical System Image ww51-2014
unity-scopes-shell (Ubuntu)
Invalid
Undecided
Unassigned
unity8 (Ubuntu)
Fix Released
Undecided
Albert Astals Cid
unity8 (Ubuntu RTM)
Fix Released
Undecided
Michał Sawicz

Bug Description

I do a search in the scopes scope, and got some results with recommendations... example of the request and two results from there: https://pastebin.canonical.com/119509/

If I tap into the recommendation for a simple scope, it gets opened and with the query searched automatically, all good!

But if I tap into the recommendation for an aggregator scope, it gets opened, but the query is NOT searched automatically. It should.

Related branches

lp:~aacid/unity8/list_on_bottom_swipe
Nick Dedekind (community): Approve
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Benjamin Keyser (community): Approve (design)
Diff: 2435 lines (+792/-1116)
20 files modified
debian/control (+1/-1)
po/unity8.pot (+41/-45)
qml/Dash/Dash.qml (+89/-127)
qml/Dash/DashContent.qml (+11/-1)
qml/Dash/GenericScopeView.qml (+1/-1)
qml/Dash/PageHeader.qml (+11/-1)
qml/Dash/ScopesList.qml (+127/-0)
qml/Dash/ScopesListCategory.qml (+176/-0)
qml/Dash/ScopesListCategoryItem.qml (+104/-0)
qml/Dash/ScopesOverview.qml (+0/-575)
qml/Dash/ScopesOverviewAll.qml (+0/-54)
qml/Dash/ScopesOverviewFavorites.qml (+0/-73)
qml/Dash/ScopesOverviewTab.qml (+0/-74)
tests/mocks/Unity/CMakeLists.txt (+1/-1)
tests/mocks/Unity/fake_scopes.cpp (+57/-3)
tests/mocks/Unity/fake_scopes.h (+8/-3)
tests/mocks/Unity/fake_scopesoverview.cpp (+77/-11)
tests/mocks/Unity/fake_scopesoverview.h (+18/-3)
tests/qmltests/Dash/tst_Dash.qml (+70/-142)
tests/qmltests/Dash/tst_GenericScopeView.qml (+0/-1)
lp:ubuntu/vivid-proposed/unity8
lp:~unity-team/unity8/rtm-14.09-staging
Unity Team: Pending requested
Diff: 77 lines (+23/-4)
3 files modified
qml/Stages/SpreadDelegate.qml (+8/-1)
tests/mocks/Unity/Application/ApplicationManager.cpp (+7/-0)
tests/qmltests/Stages/tst_SpreadDelegate.qml (+8/-3)
Paweł Stołowski (stolowski)
summary: - Canned queries to an aggregator scope: search queries not working
+ Canned queries to favorited scopes don't preserve search query string
Changed in unity-scopes-shell (Ubuntu):
status: New → Confirmed
assignee: nobody → Pawel Stolowski (stolowski)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

It seems to be affecting favorited scopes, not aggregators.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

After debugging the plugin I couldn't find anything wrong with it; I think it's actually the problem of unity8 - the following snippet of Dash.qml ( the caluse for favorite scope) looks like the culprit:

if (scopeIndex >= 0) {
                // Is a favorite one
                setCurrentScope(scopeId, false, false);
                dashContentCache.scheduleUpdate();
                showDashFromPos(pos, size);
                hide();
            } else {
                // Is not a favorite one, activate and get openScope
                scope.activate(result);
            }

Changed in unity-scopes-shell (Ubuntu):
status: Confirmed → Invalid
assignee: Pawel Stolowski (stolowski) → nobody
Revision history for this message
Albert Astals Cid (aacid) wrote :

This should be fixed in https://code.launchpad.net/~aacid/unity8/list_on_bottom_swipe/+merge/235266 where all the clicks just go through scope.activate(result);

Changed in unity8 (Ubuntu):
assignee: nobody → Albert Astals Cid (aacid)
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.01+15.04.20141205-0ubuntu1

---------------
unity8 (8.01+15.04.20141205-0ubuntu1) vivid; urgency=low

  [ CI Train Bot ]
  * Resync trunk

  [ Albert Astals ]
  * Replace Scopes Overview by the new Manage Dash (LP: #1386698,
    #1368670)
 -- Ubuntu daily release <email address hidden> Fri, 05 Dec 2014 10:55:50 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu RTM):
status: New → In Progress
assignee: nobody → Michał Sawicz (saviq)
Albert Astals Cid (aacid)
Changed in unity8 (Ubuntu RTM):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: none → ww51-2014
status: New → Fix Released
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.