Further performance optimizations needed: image loading
Bug #1380987 reported by
David Planella
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Notes app |
Fix Released
|
Critical
|
Michael Zanetti | ||
reminders-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
After testing the evernote300 account with a fresh set of (many) images uploaded to it, I noticed the following:
- At the beginning, the app does not slow down, however, it loads a few images (not those that are in view, though) and then it gets busy downloading all of the rest. Meaning you cannot really view any other notes, as it seems to be busy downloading other things. It does not block the UI, but it's always showing the busy activity indicator.
- Ultimately the app becomes unresponsive and crashes
Related branches
lp:~mzanetti/reminders-app/only-resources
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- David Planella: Approve
-
Diff: 444 lines (+84/-47)10 files modifiedpo/com.ubuntu.reminders.pot (+50/-30)
src/libqtevernote/jobs/evernotejob.cpp (+3/-0)
src/libqtevernote/jobs/evernotejob.h (+0/-1)
src/libqtevernote/jobs/fetchnotejob.cpp (+6/-5)
src/libqtevernote/jobs/fetchnotejob.h (+8/-3)
src/libqtevernote/jobs/savenotebookjob.h (+2/-0)
src/libqtevernote/jobs/savenotejob.h (+2/-0)
src/libqtevernote/jobs/savetagjob.h (+2/-0)
src/libqtevernote/notesstore.cpp (+8/-6)
src/libqtevernote/notesstore.h (+3/-2)
lp:~mzanetti/reminders-app/improve-sorting
- David Planella: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 33 lines (+14/-1)2 files modifiedsrc/plugin/Evernote/notes.cpp (+12/-0)
src/plugin/Evernote/notes.h (+2/-1)
Changed in reminders-app: | |
assignee: | nobody → David Planella (dpm) |
assignee: | David Planella (dpm) → Michael Zanetti (mzanetti) |
Changed in reminders-app: | |
milestone: | none → 2014-11-13 |
Changed in reminders-app: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The linked branch should optimize downloading a little, however, I'm having troubles to reproduce all the things. It seems to stay reasonably responsive here, even with all the pictures. Reading through the code I think we've done as much optimization to the images as we can. For example, we're caching images, only loading new ones from the network. Also when we download an image we're scaling it down for the preview in the notes list and saving that scaled down version to disk to not have to resize a second time.
Can you please test the linked branch and see if it behaves good enough now?