"Abort operation" action name is vague and misleading

Bug #1378837 reported by Graham Binns
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Graham Binns

Bug Description

The "Abort operation" action — which currently only aborts disk erasing — is misleadingly-named at best. It gives the user the impression that they can abort whatever they're doing (deploying, for example) by selecting it and clicking "Go", but in fact they'll just get an error — because if the node isn't in the DISK_ERASING state, Node.abort_operation() raises a NodeStateViolation.

Tags: confusing-ui

Related branches

Graham Binns (gmb)
Changed in maas:
milestone: none → 1.7.0
Revision history for this message
Christian Reis (kiko) wrote :

The right way to fix this bug is not to have that action exist at all, which I believe Raphael and Jason have a plan for. For 1.7, I agree with just renaming it and living with the wart, but let's count the days until I regret that when it gets pointed out.

Graham Binns (gmb)
Changed in maas:
assignee: nobody → Graham Binns (gmb)
Graham Binns (gmb)
Changed in maas:
status: Triaged → In Progress
Revision history for this message
Jason Hobbs (jason-hobbs) wrote :

We don't want to have an additional 'abort' action for each state we're in, nor an additional API for aborting each state we're in.

This action should eventually replace the 'Abort Commissioning' operation and should be extended to work for other operations too. There is a corresponding 'abort_operation' call on the API already too.

re: kiko's comment. I'm not sure how you could get away with not having an 'Abort' action/API call - there needs to be a way for a user to cancel this potentially very long running operation. We don't have any plans right now to get rid of this, that I know of.

Changed in maas:
status: In Progress → Fix Committed
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.