gallery-app

Cropping, rotating not working reliably

Bug #1377298 reported by Pat McGowan on 2014-10-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	gallery-app	Fix Released	Critical	Florian Boucault
	gallery-app (Ubuntu RTM)	Fix Released	Undecided	Unassigned

Bug Description

Take a photo with the camera
Go to the gallery
select the photo
select edit
select crop
move the crop lines and hit the checkmark
the photo does not crop
it does seem to distort the aspect ratio

Also, revert to original doesnt seem to work

rtm-proposed r68 on both mako and krillin

See original description

Tags:

Related branches

lp:~fboucault/gallery-app/respect_exif_orientation

Merged into lp:gallery-app at revision 1098

Bill Filler (community): Approve on 2014-10-10

PS Jenkins bot: Needs Fixing (continuous-integration) on 2014-10-09

Arthur Mello (community): Approve on 2014-10-09

lp:ubuntu/utopic-proposed/gallery-app

Pat McGowan (pat-mcgowan) on 2014-10-03

description:	updated
Changed in gallery-app:
importance:	Undecided → Critical

Pat McGowan (pat-mcgowan) on 2014-10-04

tags:

added: rtm14 touch-2014-10-16

Revision history for this message

Bill Filler (bfiller) wrote on 2014-10-06:

I think this might be related to the busted libthumbnailer thing https://bugs.launchpad.net/ubuntu/+source/thumbnailer/+bug/1376500

Changed in gallery-app:
assignee:	nobody → Ugo Riboni (uriboni)

Revision history for this message

Bill Filler (bfiller) wrote on 2014-10-06:

@ugo
Please install thumbnailer from silo 6 PPA (see http://people.canonical.com/~platform/citrain_dashboard/#?distro=ubuntu-rtm&q=) which reverts the change to use the thumbnail from the exif and see if cropping starts working again.

I'm guessing the problem is the thumbnail we are trying to display.

Revision history for this message

Rick Spencer (rick-rickspencer3) wrote on 2014-10-07:

This worked find for me on krillin r88

Revision history for this message

Bill Filler (bfiller) wrote on 2014-10-08:

was only an issue due to the thumbnailer change that got reverted

Changed in gallery-app:
status:	New → Invalid

Bill Filler (bfiller) on 2014-10-08

Changed in gallery-app:
status:	Invalid → Confirmed
assignee:	Ugo Riboni (uriboni) → Florian Boucault (fboucault)
summary:	- Cropping not working + Cropping, rotating not working reliable
summary:	- Cropping, rotating not working reliable + Cropping, rotating not working reliably

Revision history for this message

Bill Filler (bfiller) wrote on 2014-10-08:

IMG_0916.JPG Edit (2.2 MiB, image/jpeg)

So the change to thumbnailer has been reverted, and we landed a fix to gallery to use the high-res image in the picture view instead of the thumbnail. See this MR: https://code.launchpad.net/~phablet-team/gallery-app/do-not-upscale-thumbnail/+merge/237314

That change seemed to have caused the following issues:
1) Rotating the picture now only rotates the thumbnail but does not update the picture in the viewer
2) The orientation of pictures in the picture view is sometimes incorrect. The picture (see attached) shows up in portrait mode in the thumbnail view but show up rotated 90 degrees in the photo view. This did not occur before. Guessing it's the same problem as rotate not working.
3) Crop seems to work. But if you rotate the picture first, it doesn't show up rotated. But then when you press crop you see it rotated. Very weird.

Florian Boucault (fboucault) on 2014-10-09

Changed in gallery-app:
status:	Confirmed → In Progress

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-10-10:

This bug was fixed in the package gallery-app - 0.0.67+14.10.20141010-0ubuntu1

---------------
gallery-app (0.0.67+14.10.20141010-0ubuntu1) 14.09; urgency=low

  [ Bill Filler ]
  * Scale the album title proportionally to the album itself, so it
    works on all devices. (LP: #1377767)

[ Ubuntu daily release ]
* New rebuild forced

  [ Florian Boucault ]
  * Respect EXIF orientation when showing a photo by starting to use the
    GalleryStandardImageProvider again. (LP: #1377298)

[ Jussi Pakkanen ]
* Fix thumbnailer import. (LP: #1368492)

  [ Ugo Riboni ]
  * Scale the album title proportionally to the album itself, so it
    works on all devices. (LP: #1377767)
-- Ubuntu daily release <email address hidden> Fri, 10 Oct 2014 01:30:08 +0000