Enable/disable switches don't really alter the account's ACL
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Online Accounts setup for Ubuntu Touch |
Fix Released
|
High
|
Alberto Mardegan |
Bug Description
Since the Online Accounts UI was moved into the same process of the ubuntu-
The reason is that the ApplicationManager C++ class is not exposed to QML anymore, as can be seen from the logs of ubuntu-
2014-10-03 10:33:41,987 - WARNING - file://
2014-10-03 10:33:48,471 - WARNING - file://
Related branches
- David Barth (community): Approve
-
Diff: 827 lines (+293/-49)33 files modified.bzrignore (+6/-2)
debian/control (+13/-0)
debian/libonline-accounts-client-dev.install (+1/-1)
debian/libonline-accounts-plugin-dev.install (+2/-0)
debian/ubuntu-system-settings-online-accounts.install (+1/-1)
online-accounts-ui/access-model.cpp (+1/-1)
online-accounts-ui/online-accounts-ui.pro (+0/-4)
online-accounts-ui/panel-request.cpp (+0/-3)
online-accounts-ui/provider-request.cpp (+1/-1)
online-accounts-ui/signonui-request.cpp (+2/-2)
plugins/OnlineAccountsPlugin/OnlineAccountsPlugin.pc.in (+5/-1)
plugins/OnlineAccountsPlugin/OnlineAccountsPlugin.pro (+47/-0)
plugins/OnlineAccountsPlugin/account-manager.cpp (+0/-1)
plugins/OnlineAccountsPlugin/account-manager.h (+2/-1)
plugins/OnlineAccountsPlugin/application-manager.cpp (+5/-5)
plugins/OnlineAccountsPlugin/application-manager.h (+3/-1)
plugins/OnlineAccountsPlugin/global.h (+34/-0)
plugins/module/module.pro (+28/-3)
plugins/module/plugin.cpp (+44/-0)
plugins/module/plugin.h (+42/-0)
plugins/module/qmldir.in (+1/-0)
plugins/plugins.pro (+3/-0)
tests/online-accounts-ui/online-accounts-ui.pri (+2/-0)
tests/online-accounts-ui/online-accounts-ui.pro (+0/-1)
tests/online-accounts-ui/tst_access_model.pro (+6/-3)
tests/online-accounts-ui/tst_browser_request.pro (+1/-1)
tests/online-accounts-ui/tst_signonui_request.pro (+6/-5)
tests/plugin/plugin.pri (+18/-0)
tests/plugin/plugin.pro (+3/-0)
tests/plugin/tst_application_manager.cpp (+7/-2)
tests/plugin/tst_application_manager.pro (+5/-7)
tests/tests.pro (+2/-1)
ubuntu-system-settings-online-accounts.pro (+2/-2)
Changed in ubuntu-system-settings-online-accounts: | |
assignee: | nobody → Alberto Mardegan (mardy) |
importance: | Undecided → High |
status: | New → Confirmed |
tags: | added: ota-1 rtm14 touch-2014-10-09 |
Changed in ubuntu-system-settings-online-accounts: | |
status: | Confirmed → In Progress |
Changed in ubuntu-system-settings-online-accounts: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-system-settings-online-accounts: | |
status: | Fix Committed → Fix Released |
A clarification on the impact of this bug: if an application is granted access to an account via the in-app flow (that is, if the user doesn't manually go to the system settings to enable the app), then everything works fine as expected.
The bug is affecting the usability of the applications only if the user enables an application from the system settings, and the application has never been enabled before (by "enabled" here I mean "granted access to a specific account").
If you are hit by this bug, then you need to go visit the account in the System Settings, disable the affected application from there, then restart the application. If the application has the right code to talk to OA (unfortunately, at the moment the facebook and twitter webapp don't), then the user will be prompted to authorize the application, and things should work.