Ubuntu UX

[sdk] Checkbox in ListItem missing haptic response

Bug #1372563 reported by Ondrej Kubik
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu UX
Fix Released
Medium
Unassigned
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned
Vivid
New
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu RTM)
Confirmed
Undecided
Unassigned

Bug Description

utopic-proposed-krillin r40
Ubuntu 14.10 r257

1. Go to System Settings > "Sound", a screen that contains both switches and checkboxes.
2. Tap on a switch or checkbox.
3. Tap on the label next to a switch or checkbox.

What happens:
2. Tapping on the switch or checkbox gives haptic feedback.
3. Tapping on the label similarly toggles the control, but with no haptic feedback.

What should happen: Tapping on the label behaves exactly the same as tapping on the control itself.

One way of fixing this bug would be to add haptic feedback to the labels. Another would be to remove haptic feedback for taps altogether (bug 1267592).

Code example:

            ListItem.Standard {
                control: CheckBox {
                    objectName: "callVibrate"
                    checked: true
                }
                text: i18n.tr("Vibrate when ringing")
            }

See original description
Tags: design-sync

Related branches

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/noImpliedControlClicking
PS Jenkins bot: Approve (continuous-integration)
Zsombor Egri: Approve
Diff: 54 lines (+3/-19)
2 files modified
modules/Ubuntu/Components/ListItems/Standard.qml (+2/-16)
tests/unit_x11/tst_components/tst_listitems_standard.qml (+1/-3)
lp:ubuntu/vivid-proposed/ubuntu-ui-toolkit
Olga Kemmet (olga-kemmet)
summary: - Checkbox missing haptic response
+ [system-settings] Checkbox missing haptic response
Changed in ubuntu-ux:
assignee: nobody → Matthew Paul Thomas (mpt)
Revision history for this message
Sebastien Bacher (seb128) wrote : Re: [system-settings] Checkbox missing haptic response

that's a toolkit issue, we are using the standard widget and it's handling the haptic response

affects: ubuntu-system-settings (Ubuntu) → ubuntu-ui-toolkit (Ubuntu)
Matthew Paul Thomas (mpt)
description: updated
Cris Dywan (kalikiana)
description: updated
summary: - [system-settings] Checkbox missing haptic response
+ Checkbox in ListItem missing haptic response
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Confirmed
Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → In Progress
Matthew Paul Thomas (mpt)
Changed in ubuntu-ux:
assignee: Matthew Paul Thomas (mpt) → Giorgio Venturi (giorgio-venturi)
Matthew Paul Thomas (mpt)
Changed in ubuntu-ux:
importance: Undecided → Medium
status: New → Triaged
Zoltan Balogh (bzoltan)
affects: ubuntu-ui-toolkit (Ubuntu) → ubuntu-ui-toolkit
Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → In Progress
Zoltan Balogh (bzoltan)
no longer affects: ubuntu-ui-toolkit
Revision history for this message
Cris Dywan (kalikiana) wrote : Re: Checkbox in ListItem missing haptic response

I'm told the design has changed, so that the CheckBox is *not* supposed to activate at all unless you actually tap the CheckBox. Can this be clarified? As this completely changes the solution to this bug.

Olga Kemmet (olga-kemmet)
summary: - Checkbox in ListItem missing haptic response
+ [sdk] Checkbox in ListItem missing haptic response
Revision history for this message
Olga Kemmet (olga-kemmet) wrote :

Comment #2 is correct. The toggle or checkbox should only switch if they are actually tapped. Tapping anywhere outside the tappable area should not do any changes.

Zsombor Egri (zsombi)
tags: added: desing-sync
Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1364+15.04.20141209-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1364+15.04.20141209-0ubuntu1) vivid; urgency=medium

  [ Zsombor Egri ]
  * Theming fixes: application theming, binding loop fix, auto-theming
    moved into MainView and it is applicable only on Ambiance and
    SuruDark, SuruGradient is no longer auto-themed.
    Fixes: LP: #1213043, LP: #1277647, LP: #1330510, LP: #1356779,
           LP: #1389792.
  * ServiceProperties component to Ubuntu.Components 1.1.
    Fixes: LP: #1391877.
  * New ListItem component base. Support for leading/trailing actions.
    Exported in Ubuntu.Components 1.2 UNSTABLE release.
    Fixes: LP: #1097728, LP: #1372592, LP: #1383870.
  * removing failing ServiceProperties and app-theming branches
  * Application theming ant other theming related binding loop fixes
  * ServiceProperties DBus property watcher

  [ Christian Dywan ]
  * Do the default theme check properly: for non-debug and without
    build errors.
  * Don't activate the control in ListItem.Standard implicitly.
    Fixes: LP: #1372563.
  * Improve AutoPilot caret dragging test cases.
  * Use new qt_gl_set_global_share_context setter with Qt 5.4.
    Fixes: LP: #1397979.
  * Add sortCaseSensitivity to the SortFilterModel example.
    Fixes: LP: #1391034.
  * Change offending links into bold font. Fixes: LP: #1395011.

  [ Daniel d'Andrada ]
  * This is needed by unity8 for the "shell rotation" feature (ie
    shell does all the rotation work instead of apps rotating
    themselves). unity8's dialogs (like the power dialog when you
    long press the power button) should follow its parent item
    rotation and size, as one would expect, and not be sneakily
    reparented to the scene root item, in which case the shell
    UI would be rotated but its dialog would not.
    Related bug LP: #1394511. Fixes: LP: #1394511.

  [ Tim Peeters ]
  * Remove the old header separator style. Fixes: LP: #1372590.

  [ Loïc Molinari ]
  * Made the UCAlarmPrivate destructor private.

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Tue, 09 Dec 2014 11:47:33 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
Giorgio Venturi (giorgio-venturi-deactivatedaccount)
tags: added: design-sync
removed: desing-sync
Changed in ubuntu-ux:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.