Ubuntu
unity8 package

Clicking a snap decision button makes the foreground application inactive

Bug #1370240 reported by Gustavo Pichorim Boiko
38
This bug affects 5 people
Affects Status Importance Assigned to Milestone
unity8 (Ubuntu)
Fix Released
High
Josh Arenson
unity8 (Ubuntu RTM)
Fix Released
Critical
Josh Arenson

Bug Description

Steps to reproduce:

1) open an application
2) trigger a snap decision (by receiving a call or something like that)
3) click the snap decision buttons

Expected behavior:
- the foreground application might temporarily switch to active=false while the snap decision is visible or during the interaction with the actions, but should be set back to active=true

What happens:
- when clicking the snap decision action the application active property is set to false and kept like that.

Related branches

lp:~josharenson/unity8/better_snap_decision_fix
Superseded for merging into lp:unity8/rtm-14.09
Unity Team: Pending requested
Diff: 137 lines (+94/-1)
2 files modified
qml/Shell.qml (+1/-1)
tests/qmltests/tst_Shell.qml (+93/-0)
Superseded for merging into lp:unity8
Michael Zanetti (community): Needs Fixing
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Gerry Boland (community): Approve
Diff: 137 lines (+94/-1)
2 files modified
qml/Shell.qml (+1/-1)
tests/qmltests/tst_Shell.qml (+93/-0)
lp:~mzanetti/unity8/fix_snap_decision_test
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Gerry Boland: Pending requested
Michał Sawicz: Pending requested
Michael Zanetti: Pending requested
Josh Arenson: Pending requested
Diff: 242 lines (+130/-43)
3 files modified
qml/Notifications/Notifications.qml (+1/-0)
qml/Shell.qml (+1/-1)
tests/qmltests/tst_Shell.qml (+128/-42)
Superseded for merging into lp:unity8/rtm-14.09
Unity Team: Pending requested
Diff: 8923 lines (+5204/-843)
127 files modified
CMakeLists.txt (+2/-0)
debian/changelog (+27/-0)
debian/control (+1/-1)
debian/unity8-private.install (+1/-0)
libs/CMakeLists.txt (+1/-0)
libs/UbuntuGestures/CMakeLists.txt (+40/-0)
libs/UbuntuGestures/CandidateInactivityTimer.cpp (+41/-0)
libs/UbuntuGestures/CandidateInactivityTimer.h (+49/-0)
libs/UbuntuGestures/DebugHelpers.cpp (+68/-0)
libs/UbuntuGestures/DebugHelpers.h (+29/-0)
libs/UbuntuGestures/Pool.h (+134/-0)
libs/UbuntuGestures/Timer.cpp (+109/-0)
libs/UbuntuGestures/Timer.h (+105/-0)
libs/UbuntuGestures/TouchOwnershipEvent.cpp (+35/-0)
libs/UbuntuGestures/TouchOwnershipEvent.h (+50/-0)
libs/UbuntuGestures/TouchRegistry.cpp (+500/-0)
libs/UbuntuGestures/TouchRegistry.h (+182/-0)
libs/UbuntuGestures/UbuntuGesturesGlobal.h (+23/-0)
libs/UbuntuGestures/UnownedTouchEvent.cpp (+39/-0)
libs/UbuntuGestures/UnownedTouchEvent.h (+45/-0)
plugins/Dash/listviewwithpageheader.cpp (+1/-1)
plugins/Ubuntu/Gestures/AxisVelocityCalculator.h (+2/-2)
plugins/Ubuntu/Gestures/CMakeLists.txt (+26/-7)
plugins/Ubuntu/Gestures/Direction.h (+2/-2)
plugins/Ubuntu/Gestures/DirectionalDragArea.cpp (+335/-209)
plugins/Ubuntu/Gestures/DirectionalDragArea.h (+37/-29)
plugins/Ubuntu/Gestures/TimeSource.h (+2/-2)
plugins/Ubuntu/Gestures/TouchGate.cpp (+347/-0)
plugins/Ubuntu/Gestures/TouchGate.h (+126/-0)
plugins/Ubuntu/Gestures/UbuntuGesturesQmlGlobal.h (+3/-3)
plugins/Ubuntu/Gestures/plugin.cpp (+3/-1)
plugins/Ubuntu/Gestures/plugin.h (+1/-1)
plugins/Ubuntu/Gestures/qmldir (+1/-1)
po/ast.po (+9/-8)
po/en_AU.po (+16/-22)
po/es.po (+5/-5)
po/fa.po (+4/-10)
po/fr.po (+5/-5)
po/gd.po (+4/-4)
po/hu.po (+3/-9)
po/is.po (+9/-9)
qml/Components/Carousel.qml (+2/-3)
qml/Components/DragHandle.qml (+2/-2)
qml/Components/EdgeDragArea.qml (+2/-0)
qml/Components/Flickables/Flickable.qml (+23/-0)
qml/Components/Flickables/GridView.qml (+25/-0)
qml/Components/Flickables/ListView.qml (+25/-0)
qml/Components/Flickables/ListViewWithPageHeader.qml (+23/-0)
qml/Components/InputMethod.qml (+13/-0)
qml/Components/ListItems/Highlight.qml (+0/-46)
qml/Components/ResponsiveGridView.qml (+2/-1)
qml/Components/ZoomableImage.qml (+2/-2)
qml/Dash/CardHorizontalList.qml (+2/-1)
qml/Dash/Dash.qml (+29/-7)
qml/Dash/DashCategoryBase.qml (+4/-58)
qml/Dash/DashContent.qml (+6/-4)
qml/Dash/DashNavigationButton.qml (+2/-1)
qml/Dash/DashNavigationList.qml (+2/-1)
qml/Dash/GenericScopeView.qml (+4/-3)
qml/Dash/PageHeader.qml (+2/-1)
qml/Dash/PreviewListView.qml (+2/-3)
qml/Dash/Previews/Preview.qml (+2/-1)
qml/Dash/Previews/PreviewImageGallery.qml (+3/-2)
qml/Dash/Previews/PreviewTextSummary.qml (+1/-1)
qml/Dash/ScopeListView.qml (+3/-6)
qml/Dash/ScopeSettingsPage.qml (+2/-1)
qml/Dash/ScopesOverviewAll.qml (+2/-1)
qml/Dash/ScopesOverviewFavorites.qml (+4/-2)
qml/Greeter/LoginList.qml (+2/-2)
qml/Hud/Hud.qml (+2/-1)
qml/Hud/HudParametrizedActionsPage.qml (+2/-1)
qml/Launcher/Launcher.qml (+3/-1)
qml/Launcher/LauncherPanel.qml (+3/-1)
qml/Notifications/Notification.qml (+2/-1)
qml/Notifications/Notifications.qml (+3/-1)
qml/Panel/IndicatorRow.qml (+2/-1)
qml/Panel/Indicators/DefaultIndicatorPage.qml (+2/-1)
qml/Panel/Indicators/client/IndicatorsList.qml (+2/-1)
qml/Panel/Indicators/client/IndicatorsTree.qml (+2/-1)
qml/Panel/MenuContent.qml (+3/-2)
qml/Shell.qml (+56/-22)
qml/Stages/ApplicationWindow.qml (+0/-18)
qml/Stages/PhoneStage.qml (+16/-6)
qml/Stages/SessionContainer.qml (+1/-13)
qml/Stages/SurfaceContainer.qml (+38/-7)
qml/Stages/TabletStage.qml (+2/-1)
src/CMakeLists.txt (+6/-0)
src/Dash/CMakeLists.txt (+5/-0)
src/Dash/main.cpp (+6/-0)
src/main.cpp (+5/-0)
tests/CMakeLists.txt (+1/-0)
tests/autopilot/unity8/shell/emulators/dash.py (+1/-1)
tests/libs/CMakeLists.txt (+1/-0)
tests/libs/UbuntuGestures/CMakeLists.txt (+20/-0)
tests/libs/UbuntuGestures/tst_TouchRegistry.cpp (+803/-0)
tests/mocks/AccountsService/AccountsService.cpp (+5/-3)
tests/mocks/AccountsService/AccountsService.h (+1/-0)
tests/mocks/Unity/Application/CMakeLists.txt (+1/-0)
tests/mocks/Unity/Application/MirSurfaceItem.cpp (+18/-22)
tests/mocks/Unity/Application/MirSurfaceItem.h (+18/-1)
tests/mocks/Unity/Application/MirSurfaceItem.qml (+0/-12)
tests/mocks/Unity/Application/UbuntuKeyboardInfo.cpp (+28/-0)
tests/mocks/Unity/Application/UbuntuKeyboardInfo.h (+60/-0)
tests/mocks/Unity/Application/plugin.cpp (+7/-0)
tests/plugins/Ubuntu/Gestures/CMakeLists.txt (+9/-2)
tests/plugins/Ubuntu/Gestures/RightwardsLauncher.qml (+3/-0)
tests/plugins/Ubuntu/Gestures/touchGateExample.qml (+27/-0)
tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp (+494/-17)
tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.qml (+1/-0)
tests/plugins/Ubuntu/Gestures/tst_TouchGate.cpp (+345/-0)
tests/qmltests/Components/CMakeLists.txt (+2/-1)
tests/qmltests/Components/tst_DragHandle.cpp (+14/-17)
tests/qmltests/Greeter/tst_SingleGreeter.qml (+1/-1)
tests/qmltests/Launcher/tst_Launcher.qml (+123/-107)
tests/qmltests/Stages/tst_ApplicationWindow.qml (+2/-2)
tests/qmltests/Stages/tst_PhoneStage.qml (+2/-1)
tests/qmltests/Stages/tst_SurfaceContainer.qml (+26/-1)
tests/qmltests/tst_Shell.qml (+242/-43)
tests/qmltests/tst_ShellWithPin.qml (+94/-47)
tests/qmltests/tst_TabletShell.qml (+10/-2)
tests/uqmlscene/CMakeLists.txt (+2/-0)
tests/uqmlscene/README (+3/-1)
tests/uqmlscene/main.cpp (+9/-0)
tests/utils/modules/Unity/Test/CMakeLists.txt (+2/-0)
tests/utils/modules/Unity/Test/UnityTestCase.qml (+11/-0)
tests/utils/modules/Unity/Test/testutil.cpp (+41/-2)
tests/utils/modules/Unity/Test/testutil.h (+3/-1)
lp:~mzanetti/unity8/fix_snap_decision_test-rtm
Michał Sawicz: Approve
Diff: 244 lines (+132/-43)
3 files modified
qml/Notifications/Notifications.qml (+1/-0)
qml/Shell.qml (+1/-1)
tests/qmltests/tst_Shell.qml (+130/-42)
lp:ubuntu/vivid-proposed/unity8
Gustavo Pichorim Boiko (boiko)
summary: Clicking a snap decision button makes the foreground application
- inactive permanently
+ inactive
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unity8 (Ubuntu):
status: New → Confirmed
kevin gunn (kgunn72)
no longer affects: unity8 (Ubuntu)
Revision history for this message
Bill Filler (bfiller) wrote :

marking as critical as this is causing Bug #1368862

Changed in qtmir:
importance: Undecided → Critical
tags: added: rtm14
Revision history for this message
kevin gunn (kgunn72) wrote :

greyback - if you think josh can handle, feel free to reassign

Changed in qtmir:
assignee: nobody → Gerry Boland (gerboland)
tags: added: touch-2014-10-02
Revision history for this message
Gerry Boland (gerboland) wrote :

Can repro using lp:unity-notifications:/examples/python sd-example-incoming-call.py

Need to install python-notify package for that script to work.

To make it easier to see if app surface focused or not, use this QML file:

import QtQuick 2.0

Rectangle {
    color: (Qt.application.active) ? "green" : "red"
}

and run with:

qmlscene file.qml --desktop_file_hint=/usr/share/application/mediaplayer-app.desktop

Changed in qtmir:
assignee: Gerry Boland (gerboland) → Josh Arenson (josharenson)
status: New → Triaged
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

This seems to be the cause of https://bugs.launchpad.net/ubuntu/+source/dialer-app/+bug/1374015 in the dialer app, so it has quite bad effect there.

Revision history for this message
Josh Arenson (josharenson) wrote :

Reports state that this bug did _not_ exist in early September, but I have been unable to find anything in unity8 or qtmir that would have caused this issue. It seems that Shell is firing onActiveFocusChanged for the Notifications element, but the corresponding slot in qtmir/mirsurfaceitem

304: connect(this, &QQuickItem::activeFocusChanged, this, &MirSurfaceItem::updateMirSurfaceFocus)

is never being reached. Thus, the shell never receives surface focus after any of the input elements (buttons, text box) on the snap decision are touched and/or pressed.

After discussion, two solutions were proposed

option 1: make PhoneStage a FocusScope, and enable focus so that "spreadRepeater" will get focus if its parent gets focus. Then also have SpreadDelegate a FocusScope, and try to have the chain of focuses lead to the ApplicationWindow

option 2: Add function to PhoneStage called restoreFocus(). Add same function to SpreadDelegate, which calls ApplicationWindow's forceSurfaceActiveFocusIfReady method. Connect up those functions, so if PhoneStage::restoreFocus is called, it ends up calling the correct instance of forceSurfaceActiveFocusIfReady, and then in Shell.qml have similar function, which calls "applicationsDisplayLoader.item.restoreFocus()"

Option 1 seems more correct, but option 2 seems easier to implement.

Revision history for this message
Josh Arenson (josharenson) wrote :

To clarify

"Reports state that this bug did _not_ exist in early September, but I have been unable to find anything in unity8 or qtmir that would have caused this issue. "

I diffed qtmir-rev248 and unity8-rev1270 against trunk and couldn't find anything that would have 'introduced' this issue.

Revision history for this message
kevin gunn (kgunn72) wrote :

Just to update on this, the branch attached is being reworked for something requiring a tad more effort, but is "better" architecturally. But the root cause & the needed solution is fully understood. I'll let Josh or Gerry speak to specifics.

kevin gunn (kgunn72)
Changed in qtmir:
status: Triaged → In Progress
tags: added: touch-2014-10-09
removed: touch-2014-10-02
Olli Ries (ories)
tags: added: touch-2014-10-16
removed: touch-2014-10-09
Michał Sawicz (saviq)
affects: qtmir → unity8 (Ubuntu)
Changed in unity8 (Ubuntu RTM):
status: New → In Progress
importance: Undecided → Critical
assignee: nobody → Josh Arenson (josharenson)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.00+14.10.20141015.4~rtm-0ubuntu1

---------------
unity8 (8.00+14.10.20141015.4~rtm-0ubuntu1) 14.09; urgency=low

  [ Michał Sawicz ]
  * remove qml ownership confusion for caching unitymenumodels (LP:
    #1368856)

  [ josharenson ]
  * Fix lp:1370240 by making stages interactive when a snap decision is
    dismissed. (LP: #1370240)

  [ Nick Dedekind ]
  * remove qml ownership confusion for caching unitymenumodels (LP:
    #1368856)
  * Implementation of expandable panel design (LP: #1368856)

  [ Albert Astals ]
  * CardAttributes: Specify column and row since the gridlayout gets
    confused sometimes (LP: #1381092)
  * Reset VerticalJournal until the cardTool settles (LP: #1381255)

  [ Mirco Müller ]
  * Added synchronous/confirmation notification support to unity8. (LP:
    #1232633)

  [ Michael Zanetti ]
  * drop all visual indication of "pinning" (LP: #1381054)
  * Fix lp:1370240 by making stages interactive when a snap decision is
    dismissed. (LP: #1370240)

  [ Antti Kaijanmäki ]
  * Unlock all modems on boot. (LP: #1333121)
 -- Ubuntu daily release <email address hidden> Wed, 15 Oct 2014 16:44:20 +0000

Changed in unity8 (Ubuntu RTM):
status: In Progress → Fix Released
kevin gunn (kgunn72)
Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
kevin gunn (kgunn72)
Changed in unity8 (Ubuntu):
status: Fix Released → In Progress
Olli Ries (ories)
Changed in unity8 (Ubuntu):
importance: Critical → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.00+15.04.20141030-0ubuntu1

---------------
unity8 (8.00+15.04.20141030-0ubuntu1) vivid; urgency=low

  [ josharenson ]
  * Fix lp:1370240 by making stages interactive when a snap decision is
    dismissed. (LP: #1370240)

  [ Nick Dedekind ]
  * remove qml ownership confusion for caching unitymenumodels (LP:
    #1368856)
  * Implementation of expandable panel design (LP: #1368856)

  [ Albert Astals ]
  * CardAttributes: Specify column and row since the gridlayout gets
    confused sometimes (LP: #1381092)
  * Reset VerticalJournal until the cardTool settles (LP: #1381255)

  [ Mirco Müller ]
  * Added synchronous/confirmation notification support to unity8. (LP:
    #1232633)

  [ Michael Zanetti ]
  * Fix lp:1370240 by making stages interactive when a snap decision is
    dismissed. (LP: #1370240)
  * Drop all visual indication of "pinning" (LP: #1381054)

  [ Antti Kaijanmäki ]
  * Unlock all modems on boot. (LP: #1333121)
 -- Ubuntu daily release <email address hidden> Thu, 30 Oct 2014 10:51:17 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.