Validation errors when adding an Online Account to a click package

Bug #1357211 reported by David Planella
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Click Reviewers tools (obsolete)
Fix Released
High
Jamie Strandboge

Bug Description

Recently the feature whereby Online Accounts plugins can be deployed in click packages was added. One example app that will make use of it will be the Reminders app to ship the Evernote authentication plugin [1]. This essentially means adding a hook for the plugin, as follows:

"hooks": {
    "reminders": {
        "account-application": "com.ubuntu.reminders_reminders.application",
        "account-service": "@ACCOUNT_SERVICE_DIR@/com.ubuntu.reminders_reminders.service",
        "apparmor": "reminders.apparmor",
        "desktop": "com.ubuntu.reminders.desktop"
    },
    "evernote-account-plugin": {
        "account-qml-plugin": "@ACCOUNT_QML_PLUGIN_DIR@/evernote",
        "account-provider": "@ACCOUNT_PROVIDER_DIR@/com.ubuntu.reminders_evernote-account-plugin.provider"
    }
}

After doing this, click-reviewers-tools give the following error:

"The apparmor path is missing in the manifest file"

And after adding an apparmor entry in the evernote-account-plugin hook, there's a further error:

"The manifest file needs to specify if this is a app or a scope"

Are these valid checks? I.e. do I need to change my manifest file in any way, or do the click-reviewer-tools need to add support for online account plugin hooks?

Click package available here [2]

[1] https://code.launchpad.net/~dpm/reminders-app/account-click/+merge/230768
[2] http://people.canonical.com/~dpm/click/com.ubuntu.reminders_0.5.237_armhf.click

David Planella (dpm)
description: updated
David Planella (dpm)
description: updated
Revision history for this message
Daniel Holbach (dholbach) wrote :
Revision history for this message
Daniel Holbach (dholbach) wrote :
Changed in click-reviewers-tools:
assignee: nobody → Jamie Strandboge (jdstrand)
status: New → Triaged
Revision history for this message
Daniel Holbach (dholbach) wrote :

<jdstrand> popey, dholbach: if it comes in before I am done with the tools, please just make sure it conforms to http://paste.ubuntu.com/8299628/

David Planella (dpm)
description: updated
description: updated
Changed in click-reviewers-tools:
importance: Undecided → High
Changed in click-reviewers-tools:
status: Triaged → In Progress
Changed in click-reviewers-tools:
status: In Progress → Fix Released
Revision history for this message
David Planella (dpm) wrote :

Hm, this still doesn't seem fixed for the click package attached to the bug description:

$ click-review com.ubuntu.reminders_0.5.237_armhf.click
ERROR: could not find desktop hook for 'evernote-account-plugin'

description: updated
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Made a couple more updates in click-reviewers-tools 0.14.

$ click-review /tmp/com.ubuntu.reminders_0.5.237_armhf.click
Errors
------
 - online_accounts_evernote-account-plugin_account-provider
 (MANUAL REVIEW) 'account-provider' not allowed
 - online_accounts_evernote-account-plugin_account-qml-plugin
 (MANUAL REVIEW) 'account-qml-plugin' not allowed
/tmp/com.ubuntu.reminders_0.5.237_armhf.click: FAIL
[1]

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.