Mir

File descriptor leak in frontend - PromptSessionClientAPI acceptance test hang consistently after 67 iterations

Bug #1353461 reported by Alexandros Frantzis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Critical
Alexandros Frantzis
0.6
Won't Fix
Undecided
Alexandros Frantzis
0.7
Fix Released
Critical
Alexandros Frantzis
mir (Ubuntu)
Fix Released
Critical
Unassigned

Bug Description

Steps to reproduce: mir_acceptance_tests --gtest_filter=PromptSessionClientAPI.* --gtest_repeat=1000

Expected result: test passes

Actual result : test hangs consistently after 67 iterations. Consistent failures like this usually indicate that we are leaking file descriptors.

Related branches

tags: added: testsfail
Changed in mir:
importance: Medium → High
Changed in mir:
assignee: nobody → Alexandros Frantzis (afrantzis)
Changed in mir:
status: New → In Progress
Changed in mir:
milestone: none → 0.7.0
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Changed to critical since with this bug prompt sessions connections will eventually cause the server to run out of file descriptors.

tags: added: rtm15
tags: added: rtm14
removed: rtm15
Changed in mir:
importance: High → Critical
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

To be more exact requests for fds for prompt providers will eventually cause the server to run out of file descriptors.

summary: - PromptSessionClientAPI acceptance test hang consistently after 67
- iterations
+ File descriptor leak in frontend - PromptSessionClientAPI acceptance
+ test hang consistently after 67 iterations
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown

Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix committed to lp:mir/0.6 at revision 1852.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix reverted. Turns out it not only didn't build but possibly isn't required on 0.6 at all... ?

Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

I thought we had agreed to generate MPs against a release branch _after_ a release.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

You're right; I forgot. It's reverted now anyway. Nothing has landed for 0.6.2 yet.

tags: added: touch-2014-08-28
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix committed to lp:mir/0.7 r1855

Changed in mir:
milestone: 0.7.0 → 0.8.0
Changed in mir (Ubuntu):
importance: Undecided → Critical
status: New → Triaged
Changed in mir:
milestone: 0.8.0 → 0.7.0
no longer affects: mir/0.7
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix committed to:
  0.8 (development-branch) at revision 1843, scheduled for release in Mir 0.8.0
  0.7 at revision 1855, scheduled for release in Mir 0.7.0

Changed in mir:
milestone: 0.7.0 → 0.8.0
milestone: 0.8.0 → none
milestone: none → 0.8.0
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.2 KiB)

This bug was fixed in the package mir - 0.7.0+14.10.20140829-0ubuntu1

---------------
mir (0.7.0+14.10.20140829-0ubuntu1) utopic; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.7.0 (https://launchpad.net/mir/+milestone/0.7.0)
    - Enhancements:
      . Test suite: Reworked mechanism to override Mir client functions
      . Demo shell: Detect custom rendering (decorations) to make it
        compatible with overlay optimizations
      . Make sure to preserve fd resources until the end of the sending
        of the message
      . Add test cases and script for tracking changes to the new ABIs:
        libmircommon, libmirplatform
      . Symbols file for libmirplatform
      . Symbols file for libmircommon
      . Symbols file for libmirserver
      . Various improvements to the SessionMediator test
      . Various build related improvements
      . Print testcase output during package build
      . Abort test when InProcessServer startup fails
      . Link the integration and unit tests against the server objects
      . Add a document detailing the useful tests to run and the useful
        logs to collect when troubleshooting a new android chipset
      . Enable motion event resampling and prediction for a more responsive
        touch experience.
    - ABI summary: Servers need rebuilding, but clients do not
      . Mirclient ABI unchanged at 8
      . Mircommon ABI bumped to 1
      . Mirplatform ABI bumped to 2
      . Mirserver ABI bumped to 25
    - API changes
      . Deleted function - frontend::Shell::create_surface_for(). If you have
        the std::shared_ptr<frontend::Session> session, you can just do
        session->create_surface(params) instead to get a SurfaceId
    - Bug fixes:
      . Ensure we process lifecycle events before the nested server is torn
        down (LP: #1353465)
      . Fix race in InputTestingServerConfiguration (LP: #1354446)
      . Fix fd leaks in prompt session frontend code and tests (LP: #1353461)
      . Detect the additional things the demo shell draws on the renderable
        list and avoid calling the optimized post function if they are being
        drawn (LP: #1348330)
      . Client: Fix SIGTERM dispatch in our default lifecycle event handler
        (LP: #1353867)
      . DemoRenderer: Don't try to create a texture of width zero.
        (LP: #1358210)
      . Fix CI failures (LP: #1358698)
      . Fix build failure: "variable ‘rc’ set but not used" which happens in
        release mode when NDEBUG is set (LP: #1358625)
      . Only enumerate exposed input surfaces to avoid delivering events to
        occluded surfaces (LP: #1359264)
      . Android: do not post driver cancelled buffers (LP: #1359406)
      . Client: Ensure our platform library stays loaded for as long as it is
        needed by other objects (LP: #1358191)
      . Examples: Register the DemoCompositor with the Scene to properly
        process visibility events (LP: #1359487)
      . Mir_demo_client_basic: Don't assert on user errors like failing to
        connect to a Mir server (LP: #1331958)
      . Tests: Explicitly depend on GMock target to avoid build races
        (LP: #1362646)

  [ Ubuntu dai...

Read more...

Changed in mir (Ubuntu):
status: Triaged → Fix Released
Changed in mir:
milestone: 0.8.0 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.