[enhancement] It should be possible to customize configuration options without going via boost options and the commandline
Bug #1351255 reported by
Alan Griffiths
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Wishlist
|
Alan Griffiths | ||
| 0.6 |
Fix Released
|
Wishlist
|
Alan Griffiths | ||
| mir (Ubuntu) |
Fix Released
|
Wishlist
|
Unassigned | ||
Bug Description
Shells will typically want to handle their own command line and pass some options to Mir and not need to provide Mir with a command line to parse. (Unity8 would want to use QCommandLineParser for example.)
There is some separation into the mir::options but there's no effective support for building a replacement for DefaultConfigur
Related branches
lp:~alan-griffiths/mir/command-line-handling
- PS Jenkins bot (community): Approve (continuous-integration)
- Alan Griffiths: Abstain
- Robert Carr (community): Approve
- Alexandros Frantzis (community): Approve
-
Diff: 290 lines (+167/-6)9 files modifiedinclude/platform/mir/options/default_configuration.h (+5/-0)
include/platform/mir/options/program_option.h (+3/-0)
server-ABI-sha1sums (+2/-2)
src/platform/options/default_configuration.cpp (+27/-0)
src/platform/options/program_option.cpp (+9/-2)
tests/acceptance-tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/test_command_line_handling.cpp (+96/-0)
tests/acceptance-tests/test_nested_mir.cpp (+2/-2)
tests/unit-tests/options/test_program_option.cpp (+22/-0)
lp:mir/0.6
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Kevin DuBois (community): Needs Information
- Alberto Aguirre (community): Approve
-
Diff: 1037 lines (+536/-184)19 files modifiedCMakeLists.txt (+1/-1)
debian/changelog (+11/-0)
debian/control (+4/-4)
include/test/mir_test_framework/using_stub_client_platform.h (+11/-3)
src/client/api_impl.h (+0/-27)
src/client/api_impl_types.h (+0/-32)
src/client/mir_connection_api.cpp (+73/-66)
src/client/mir_connection_api.h (+59/-0)
src/platform/graphics/android/hwc_device.cpp (+19/-3)
src/platform/graphics/android/hwc_device.h (+1/-0)
src/platform/graphics/android/hwc_logger.h (+5/-0)
src/platform/graphics/android/hwc_loggers.cpp (+36/-0)
src/platform/graphics/android/hwc_loggers.h (+8/-0)
src/platform/graphics/android/real_hwc_wrapper.cpp (+4/-0)
tests/mir_test_framework/server_runner.cpp (+1/-1)
tests/mir_test_framework/using_stub_client_platform.cpp (+37/-35)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+190/-0)
tests/unit-tests/graphics/android/test_hwc_logger.cpp (+40/-0)
tests/unit-tests/graphics/android/test_hwc_wrapper.cpp (+36/-12)
Revision history for this message
| Gerry Boland (gerboland) wrote | #1 |
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | #2 |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #3 |
| Changed in mir: | |
| status: | New → Fix Committed |
| Changed in mir: | |
| milestone: | none → 0.7.0 |
| Changed in mir: | |
| milestone: | 0.7.0 → 0.6.0 |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #4 |
| Changed in mir: | |
| milestone: | 0.6.0 → 0.7.0 |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #5 |
| Changed in mir (Ubuntu): | |
| importance: | Undecided → Wishlist |
| status: | New → Fix Released |
| Changed in mir: | |
| milestone: | 0.7.0 → none |
| status: | Fix Committed → Fix Released |
| Changed in mir: | |
| milestone: | none → 0.7.0 |
| status: | Fix Released → Fix Committed |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #6 |
| Changed in mir: | |
| milestone: | 0.7.0 → none |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Agreed. We would very much like that we can combine Qt's and Mir's command line parsing and help output in a way that makes sense.
If Mir could offer a method which we pass command line arguments, and it returns a command line argument list with the mir recognised entries removed, it would help a lot.