buildd slave config hardcodes --archive=ubuntu
Bug #1348077 reported by
Colin Watson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
| launchpad-buildd |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
The template buildd slave config hardcodes --archive=ubuntu, and this is used to populate the Distribution field in ddebs.txt and translations.txt. Martin is already ignoring Distribution in ddebs.txt (though really we ought to fix it so that he stops having to guess from Release alone), but I'm not sure if this will break things for ubuntu-rtm translations. We should sort this out per-build instead.
Related branches
lp:~cjwatson/launchpad/bpbb-distribution
- William Grant: Approve (code)
-
Diff: 81 lines (+14/-12)2 files modifiedlib/lp/soyuz/model/binarypackagebuildbehaviour.py (+8/-6)
lib/lp/soyuz/tests/test_binarypackagebuildbehaviour.py (+6/-6)
lp:~cjwatson/launchpad-buildd/unhardcode-distribution
- William Grant: Approve (code)
-
Diff: 143 lines (+41/-20)5 files modifieddebian/changelog (+6/-0)
debian/upgrade-config (+16/-0)
lpbuildd/binarypackage.py (+12/-15)
lpbuildd/tests/test_binarypackage.py (+6/-4)
template-buildd-slave.conf (+1/-1)
| Changed in launchpad-buildd: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: phone-rtm |
Revision history for this message
| Colin Watson (cjwatson) wrote | #1 |
| Changed in launchpad: | |
| assignee: | nobody → Colin Watson (cjwatson) |
| importance: | Undecided → High |
| status: | New → In Progress |
| Changed in launchpad-buildd: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Colin Watson (cjwatson) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-untestable |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad-buildd: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Colin Watson (cjwatson) wrote | #3 |
| Changed in launchpad-buildd: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Launchpad doesn't actually pass the distribution name to the buildd. That can't help.