Scrobbling updates nowplaying without any meta/state change

Bug #1347990 reported by theli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Nuvola Apps Runtime (Nuvola Player)
Fix Released
High
Unassigned

Bug Description

Status
======

Fix committed to lp:nuvola-player/2.4.x as r845. Will be released in Nuvola Player 2.4.3.
<http://bazaar.launchpad.net/~fenryxo/nuvola-player/2.4.x/revision/845>

Fix committed to lp:nuvola-player as r845. Will be released in Nuvola Player 2.5.0.
<http://bazaar.launchpad.net/~fenryxo/nuvola-player/trunk/revision/845>

Original report
===============

Start nuvolaplayer, start playing any song in any service.
Pause song

Nuvola keeps sending nowplaying notification despite nor song nor playstate change.
There is no way to stop if from doing that apart from closing nuvola or switching service (to reset meta to null).

This leads to a situation where if you just pause the song (no other way, no actuall "stop" action) nuvola still keeps sending nowplaying updates every couple of seconds.

So you need to close nuvola for your nowplaying updates to work from a different place (like, leave nuvola running paused minimized and go for a walk with some other player running on your smartphone ..... and nuvolaplayer will keep overriding your nowplaying status)

From what I saw other players only update nowplaying if the state (play/paused) or metadata change. And there is no point to do that periodically from what I see.

Relevant debug output lines (with nuvola paused):
    Nuvola Debug lastfm.vala:769: lastfm update now playing: Twilight Of The Thunder God by Amon Amarth
    Nuvola Debug lastfm.vala:769: lastfm update now playing: Twilight Of The Thunder God by Amon Amarth
    Nuvola Debug lastfm.vala:769: lastfm update now playing: Twilight Of The Thunder God by Amon Amarth
    Nuvola Debug lastfm.vala:769: lastfm update now playing: Twilight Of The Thunder God by Amon Amarth
... etc

Revision history for this message
Jiří Janoušek (fenryxo) wrote :

Thanks for taking time to report this issue.

> From what I saw other players only update nowplaying if the state (play/paused) or metadata change. And there is no point to do that periodically from what I see.

If the "update now playing" is not called periodically, the now playing entry disappears from lastfm profile page. Is it expected behavior? (I would expect the now-playing entry during whole playback, but I don't use lastfm.)

Changed in nuvola-player:
status: New → Incomplete
importance: Undecided → High
Revision history for this message
theli (theli-ukr) wrote :

I'm not exactly sure how other players handle that. And lastfm's documentation is not clear on that either.
But in any case - still sending nowplaying updates when paused does not make much sense since the track is technically not playing.

I guess just stoppping sending them while paused would be a logical change.

Revision history for this message
theli (theli-ukr) wrote :

Also, lastfm's updateNowPlaying documentation says it
Used to notify Last.fm that a user has *started* listening to a track. Parameter names are case sensitive.
http://www.last.fm/api/show/track.updateNowPlaying

So it seems like it is intended to be posted (preferebly along with duration of a track) only when user started (started new or unpaused) listening a track

description: updated
Changed in nuvola-player:
status: Incomplete → Fix Committed
milestone: none → 2.4.3
Changed in nuvola-player:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.