Provisioning MVNO logic fails if match_data is shorter then IMSI
Bug #1347733 reported by
Tony Espy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ofono (Ubuntu) |
Fix Released
|
High
|
Martti Piirainen |
Bug Description
The ubuntu apn logic handles MVNOs by looking at two apn attribites, mvno_type and mvno_match_data. If the mvno_type is 'imsi', then the contents of mvno_match_data are compared to the provided IMSI. The mvno_match_data may contain wildcards indicated by the character "x", which match any digit.
If the mvno_match_data contains a string which is shorter than the actual IMSI, the matching logic fails ( eg. mvno_match_
This was discovered during testing of a recent pull request:
Related branches
lp:~phablet-team/ofono/ofono-bug-updates
- Alfonso Sanchez-Beato: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 1983 lines (+915/-168)31 files modifiedMakefile.am (+3/-0)
debian/changelog (+21/-0)
doc/networktime-api.txt (+47/-0)
doc/radio-settings-api.txt (+14/-0)
drivers/mtkmodem/gprs.c (+32/-4)
drivers/mtkmodem/mtk_constants.h (+50/-11)
drivers/mtkmodem/mtkreply.c (+68/-0)
drivers/mtkmodem/mtkreply.h (+40/-0)
drivers/mtkmodem/mtkutil.c (+92/-22)
drivers/mtkmodem/mtkutil.h (+13/-0)
drivers/mtkmodem/radio-settings.c (+53/-2)
drivers/mtkmodem/voicecall.c (+3/-3)
drivers/rilmodem/gprs-context.c (+13/-4)
drivers/rilmodem/gprs.h (+1/-0)
drivers/rilmodem/radio-settings.c (+30/-1)
drivers/rilmodem/rilutil.h (+6/-0)
gril/gril.c (+36/-2)
gril/gril.h (+20/-11)
gril/grilreply.c (+2/-2)
gril/grilrequest.c (+22/-10)
gril/grilrequest.h (+1/-0)
gril/ril_constants.h (+2/-0)
include/radio-settings.h (+11/-0)
plugins/mtk.c (+122/-26)
plugins/nettime.c (+88/-55)
plugins/ril.c (+14/-9)
plugins/ubuntu-apndb.c (+4/-2)
src/radio-settings.c (+60/-1)
test/list-modems (+2/-1)
unit/test-mtkreply.c (+43/-0)
unit/test-mtkunsol.c (+2/-2)
Changed in ofono (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Tony Espy (awe) |
Changed in ofono (Ubuntu): | |
status: | Confirmed → Fix Committed |
To post a comment you must log in.
oFono pull request https:/ /github. com/rilmodem/ ofono/pull/ 105 should fix this.