Does im-config need to be displayed in menus?

Bug #1342677 reported by Martin Wimpress 
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
im-config (Ubuntu)
Fix Released
Low
Gunnar Hjalmarsson

Bug Description

Hi,

I'm working on Ubuntu MATE Remix.

MATE provides it's own keyboard input/language configuration tools. We are using language-selector-gnome which depends on im-config. NotShowIn=MATE; should be added to im-config.desktop so that im-config icons are not displayed in System -> Preferences when running MATE.

Tags: patch
Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

Attached is a diff that resolves this issue.

description: updated
description: updated
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Do not show im-config in System -> Preferences when running MATE." seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Aron Xu (happyaron) wrote :

Can you please also submit this patch to Debian? Thanks!

Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

This "bug" can be closed. The patch is not required.

it now transpires that some users will require access to the tool even when using MATE.

Changed in im-config (Ubuntu):
status: New → Invalid
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Hmm... In general you shouldn't let "some users" prevent you from getting a sensible UI for the bulk of users. In this case the control in language-selector-gnome accesses im-config indirectly, and that is almost always sufficient.

I have thought about this for Ubuntu and other distros which use language-selector-gnome. Reopening this bug report to not forget about it.

@Aron: Do you have any thoughts? Do we really need im-config to show up in the Dash in Unity and in the menu in e.g. Xubuntu and Lubuntu (or MATE)?

Changed in im-config (Ubuntu):
status: Invalid → New
summary: - im-config doesn't need to be displayed in MATE
+ Does im-config need to be displayed in menus?
Revision history for this message
osamu (osamu) wrote :

I agree with Gunnar.

It should be disabled for all Ubuntu desktop isn't it?

Please file your proffered desktop file to Debian BTS under im-config.

I think I can make debian/rules to install different desktop file depending on distribution.

(If langage chooser can be ported to Debian, I can disable for Debian too.)

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

@Osamu: language-selector-gnome involves some Ubuntu specific solutions for language and locale handling, and would not easily be ported to Debian.

As regards the Ubuntu side, we will keep needing it for Kubuntu, since they don't use language-selector-gnome.

Final Freeze for 14.10 happens today, but I may come up with a proposal in the beginning of next cycle.

Revision history for this message
osamu (osamu) wrote :

I guess you can patch as you wish for the upcoming release on Ubuntu.

But for longer term, how about updating debian/rules as:
(Just give me the line for NotShown.)

override_dh_install:
        dh_install
        # Adjust priority for each distribution.
        # Debian: ibus (21) fcitx(22)
        # Ubuntu: fcitx(20) ibus (21)
        if dpkg-vendor --is ubuntu; then \
                cd debian/im-config/usr/share/im-config/data ; \
                mv 22_fcitx.conf 20_fcitx.conf ; \
                mv 22_fcitx.rc 20_fcitx.rc ; \
                echo "NotShowIn=MATE;GNOME" debian/im-config/usr/share/applications/im-config.desktop ;\
        fi

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

On 2014-10-17 09:34, osamu wrote:
> ... how about updating debian/rules as:

<snip>

> echo "NotShowIn=MATE;GNOME" debian/im-config/...

Nah, rather like this:

echo "OnlyShowIn=KDE;GNOME;" debian/im-config/...

"GNOME" refers to Ubuntu GNOME, and like Kubuntu they don't ship language-selector-gnome.

Changed in im-config (Ubuntu):
assignee: nobody → Gunnar Hjalmarsson (gunnarhj)
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package im-config - 0.27-1ubuntu1

---------------
im-config (0.27-1ubuntu1) vivid; urgency=low

  * Merge with Debian unstable, remaining Ubuntu changes:
    - debian/im-config.user-session.upstart
    - debian/rules:
      - Additional "cd $(CURDIR) ; \" in the Ubuntu specific code
      - Install upstart job script
    - debian/postinst: Additional condition to be met to edit
      80im-switch.

im-config (0.27-1) unstable; urgency=medium

  * Make STDERR output less verbose as default. LP: #1375089
  * Customize desktop file for Ubuntu. LP: #1342677
 -- Gunnar Hjalmarsson <email address hidden> Tue, 28 Oct 2014 14:11:00 +0100

Changed in im-config (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.