Always requests confirmation for changing music folder

Bug #1337312 reported by Sergey "Shnatsel" Davidoff
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Noise
Fix Released
Medium
Sergey "Shnatsel" Davidoff

Bug Description

Noise always requests confirmation when changing music folder and suggests that existing data will be destroyed even when there's no data to destroy. A screenshot of the prompt is attached.

The bug comes from src/LibraryWindow.vala line 1178 - it checks whether the linked list of playlists is empty, but it's never empty because Noise always has two built-in playlists "Queue" and "History".

It should probably use a smarter check, like the one in the confirmation dialog itself that makes the "Export playlists" button insensitive.

Related branches

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

The source of the issue was found using this debugging branch: lp:~shnatsel-unprivileged/noise/debug-for-bug-1337312

Changed in noise:
assignee: nobody → Sergey "Shnatsel" Davidoff (shnatsel)
status: New → Fix Committed
Cody Garver (codygarver)
Changed in noise:
milestone: none → freya-beta2
importance: Undecided → Medium
Changed in noise:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.