suspend_advanced and hibernate_advanced will be triggered while running the keys/sleep and keys/hibernate test

Bug #1330399 reported by Po-Hsu Lin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox Provider - Base
Fix Released
Undecided
Po-Hsu Lin

Bug Description

It seems that the job in the "depends:" requirement will be triggered if it's not started yet.

The key/sleep job, which depends on suspend_advanced,
but it's tested before the one it depends, so the suspend_advanced job will be triggered before it.

The same logic could be applied to the key/hibernate test as well.

Related branches

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I can confirm that this is what depends does. If job A has 'depends: B' then B will be started before A.

summary: suspend_advanced and hibernate_advanced will be triggered while running
- the key/sleep and key/hibernate test
+ the keys/sleep and keys/hibernate test
Changed in plainbox-provider-checkbox:
status: New → Triaged
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Setting to triaged. I would just remove the dependency as it shouldn't be there IMHO

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

+1. That's a good idea.

Changed in plainbox-provider-checkbox:
status: Triaged → In Progress
assignee: nobody → Po-Hsu Lin (cypressyew)
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

After look into the whitelist, I think it will be better to move the job to somewhere else, because we have some "before suspend" test need to run.
Run the suspend / hibernate key test before those test will conflict with our test plan.

Po-Hsu Lin (cypressyew)
Changed in plainbox-provider-checkbox:
status: In Progress → Fix Committed
Changed in plainbox-provider-checkbox:
milestone: none → 0.6
Changed in plainbox-provider-checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.