Checkbox Provider - Base

suspend/suspend_advanced_auto is not in client-cert.whitelist but it is shown in 'Choose tests to run on your system'

Bug #1327949 reported by Taihsiang Ho
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Checkbox Provider - Base
Fix Released
Undecided
Po-Hsu Lin
Checkbox Provider - Base 0.6

Bug Description

Steps to reproduce the bug:
1. checkbox-cli --new-ui, create new session is asked
2. choose and only choose Client-cert whitelist in the 'Suite selection'

Expected result:
1. there is no suspend/suspend_advanced_auto because it is not listed on checkbox/providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist. And we don't need this test for our certification task as well.
2. suspend/suspend_advanced_auto should not be run.

Actual result:
1. it is listed and could be selected.
2. it did be run.

-------------

package information:

ubuntu@201401-14529:~$ dpkg -l | grep checkbox
ii checkbox 0.17.9.1~ubuntu14.04.1 amd64 System testing application
ii checkbox-certification 0.19~ubuntu14.04.1 all Checkbox Certification Tests
ii checkbox-certification-client 0.19~ubuntu14.04.1 all Client Certification
ii checkbox-certification-tools 0.19~ubuntu14.04.1 all Checkbox Certification Tools
ii checkbox-gui 0.17.9~dev+bzr3043+pkg2~ubuntu14.04.1 amd64 QML based interface for system testing based on PlainBox.
ii checkbox-ng 0.4~dev+bzr3049+pkg7~ubuntu14.04.1 all PlainBox based test runner
ii checkbox-ng-service 0.4~dev+bzr3049+pkg7~ubuntu14.04.1 all CheckBox D-Bus service
ii checkbox-qt 0.17.9.1~ubuntu14.04.1 amd64 QT4 interface for checkbox
ii plainbox-provider-checkbox 0.5~dev+bzr3043+pkg5~ubuntu14.04.1 amd64 CheckBox provider for PlainBox
ii python3-checkbox 0.17.9.1~ubuntu14.04.1 all CheckBox python3 library
ii python3-checkbox-ng 0.4~dev+bzr3049+pkg7~ubuntu14.04.1 all PlainBox based test runner (Python 3 library)
ii python3-checkbox-support 0.3~dev+bzr3043+pkg3~ubuntu14.04.1 all collection of Python modules used by PlainBox providers
ubuntu@201401-14529:~$ dpkg -l | grep plainbox
ii plainbox-provider-certification-client 0.1~dev+bzr3043+pkg15~ubuntu14.04.1 all Client Certification
ii plainbox-provider-checkbox 0.5~dev+bzr3043+pkg5~ubuntu14.04.1 amd64 CheckBox provider for PlainBox
ii plainbox-provider-resource-generic 0.4~dev+bzr3043+pkg5~ubuntu14.04.1 amd64 CheckBox generic resource jobs provider
ii plainbox-secure-policy 0.6~dev+bzr3047+pkg4~ubuntu14.04.1 all policykit policy required to use plainbox (secure version)
ii python3-plainbox 0.6~dev+bzr3047+pkg4~ubuntu14.04.1 all toolkit for software and hardware testing (python3 module)
ubuntu@201401-14529:~$

Related branches

lp:~cypressyew/checkbox/fix-suspend-auto-invoked
Zygmunt Krynicki (community): Approve
Diff: 15 lines (+2/-2)
1 file modified
providers/plainbox-provider-checkbox/jobs/suspend.txt.in (+2/-2)
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

This also applies to suspend/cycle_resolutions_after_suspend_auto job.

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Quick check with current trunk shows that we indeed have 2013.com.canonical.certification::suspend/suspend_advanced_auto in the effective run list when selecting client-cert.whitelist

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

We need a tool to show reverse-depends of any job (to show which jobs pull it in as a direct or indirect dependency)

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

OK, I think I know what's happened here,
these two jobs: suspend_advanced_auto and suspend/cycle_resolutions_after_suspend_auto were triggered by their job dependency. (see bug 1330399 for a similar issue)

Fixing this will be easy, but as Zyga mentioned here, we need a validation tool for this.

Changed in checkbox-ng:
assignee: nobody → Po-Hsu Lin (cypressyew)
status: New → In Progress
Po-Hsu Lin (cypressyew)
Changed in checkbox-ng:
status: In Progress → Fix Committed
Sylvain Pineau (sylvain-pineau)
affects: checkbox-ng → plainbox-provider-checkbox
Changed in plainbox-provider-checkbox:
milestone: none → 0.6
Sylvain Pineau (sylvain-pineau)
Changed in plainbox-provider-checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.