Firmware Test Suite

doesn't build with json-c 0.12

Bug #1326911 reported by Mariusz Libera
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Firmware Test Suite
Fix Released
Medium
Colin Ian King

Bug Description

From json-c 0.12 changelog:
* Remove the old libjson.so name compatibility support. The library is
   only created as libjson-c.so now and headers are only installed
   into the ${prefix}/json-c directory.

While building fwts 14.05.00 with json-c 0.12 I got:

../../../src/lib/include/fwts_json.h:23:23: fatal error: json/json.h: No such file or directory
#include <json/json.h>
^
compilation terminated.

Revision history for this message
Colin Ian King (colin-king) wrote :

Can you provide information on how you are building fwts and on which release and distrubution you are doing the build?

Changed in fwts:
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → Colin King (colin-king)
status: In Progress → Incomplete
Revision history for this message
Mariusz Libera (mariusz-libera) wrote :

I'm using Archlinux and I'm building it using PKGBUILD script you can see here: https://aur.archlinux.org/packages/fw/fwts/PKGBUILD
Basically it downloads tarball from
http://fwts.ubuntu.com/release/
extracts it and executes following as root in a fake chroot:
autoreconf -ivf
./configure --prefix="/usr"
make

I'm maintaining that script and it was building and working fine with json-c 0.11, but about 2 weeks ago Arch updated to json-c 0.12 and now it's broken. Arch ships json-c without any patches, as you can see here: https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/json-c so there is no longer /usr/include/json/json.h

Revision history for this message
Colin Ian King (colin-king) wrote :

Just for clarification, where is json.h being installed to on Arch Linux?

Revision history for this message
Mariusz Libera (mariusz-libera) wrote :

It's in /usr/include/json-c/json.h, same as on Debian and Ubuntu, I guess.
Version 0.11 included a compatibility symlink:
/usr/include/json -> /usr/include/json-c

Colin Ian King (colin-king)
Changed in fwts:
status: Incomplete → In Progress
Revision history for this message
Colin Ian King (colin-king) wrote :

Hi Mariusz, is this still an issue with the latest versions of fwts?

Colin Ian King (colin-king)
Changed in fwts:
status: In Progress → Incomplete
Revision history for this message
Colin Ian King (colin-king) wrote :

I've checked this against Arch Linux today and the issue still occurs. I've sent a patch to the fwts-devel mailing list to address this issue, see https://lists.ubuntu.com/archives/fwts-devel/2014-September/005408.html

Changed in fwts:
status: Incomplete → In Progress
Revision history for this message
Colin Ian King (colin-king) wrote :

Fix committed, commit 5742f5e7c2677b06f64d07b6635be719375102a4

Changed in fwts:
status: In Progress → Fix Committed
Colin Ian King (colin-king)
Changed in fwts:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.