Ubuntu
gtk+3.0 package

Can't unset titlebar

Bug #1325767 reported by Robert Ancell
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gtk+3.0 (Ubuntu)
Fix Released
Wishlist
Unassigned
Trusty
Fix Released
Wishlist
Unassigned

Bug Description

[Impact]
In GTK+ unsetting a titlebar [1] does not work. This was fixed in upstream GTK+ [2]. Since Ubuntu does not work well with GtkHeaderBar it is desirable for applications to be able to conditionally unset their titlebar to work well in Ubuntu.

[Test Case]
1. Write an application that uses a Gtk.HeaderBar and unsets it [3]
2. Run application
Expected result:
Window is shown with window decorations
Observed result:
Window is shown without window decorations

[Regression Potential]
Potential for breaking existing cases where the titlebar is reset. This seems low probability given the simplicity of the patch.

[1] https://developer.gnome.org/gtk3/stable/GtkWindow.html#gtk-window-set-titlebar
[2] https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-12&id=8db2ba425aaff107faaa4c7468be63f8ef2fa8e9
[3]
int main (string[] args)
{
   Gtk.init (ref args);

   var w = new Gtk.Window ();
   var hb = new Gtk.HeaderBar ();
   hb.visible = true;
   w.set_titlebar (hb);
   w.set_titlebar (null); /* Doesn't restore decorations on GTK 3.10 */

   var l = new Gtk.Label ("Hello world!");
   l.visible = true;
   w.add (l);

   w.visible = true;

   Gtk.main ();

   return 0;
}

Robert Ancell (robert-ancell)
Changed in gtk+3.0 (Ubuntu):
status: New → Triaged
importance: Undecided → Wishlist
Changed in gtk+3.0 (Ubuntu Trusty):
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk+3.0 - 3.10.9-0ubuntu1

---------------
gtk+3.0 (3.10.9-0ubuntu1) utopic; urgency=medium

  * New upstream version
    - "Change the logic so that we only insert separators when we see a
       non-zero number of actual items in the menu before us."
       (lp: #1306850)
 -- Sebastien Bacher <email address hidden> Tue, 03 Jun 2014 15:09:52 +0200

Changed in gtk+3.0 (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Stéphane Graber (stgraber) wrote : Please test proposed package

Hello Robert, or anyone else affected,

Accepted gtk+3.0 into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gtk+3.0/3.10.8-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gtk+3.0 (Ubuntu Trusty):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Confirmed fixed in a trusty VM using gtk+3.0 3.10.8-0ubuntu1.1

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk+3.0 - 3.10.8-0ubuntu1.1

---------------
gtk+3.0 (3.10.8-0ubuntu1.1) trusty; urgency=medium

  * debian/patches/unset-titlebar.patch:
    - Allow titlebars to be unset (LP: #1325767)
 -- Robert Ancell <email address hidden> Wed, 04 Jun 2014 08:51:04 +1200

Changed in gtk+3.0 (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of the Stable Release Update for gtk+3.0 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.