neutron

dump_flows_for_table() needs to handle run_ofctl failing

Bug #1324659 reported by Kyle Mestery
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Kyle Mestery
neutron 2014.2 "juno"
Icehouse
Fix Released
High
Kyle Mestery
neutron 2014.1.1

Bug Description

The function dump_flows_for_table() calls run_ofctl() to run the "dump-flows" command. In the case of this occuring during an OVS restart, run_ofctl() will fail, and an attempt to run splitlines() is made on a None object.

Kyle Mestery (mestery)
Changed in neutron:
importance: Undecided → High
assignee: nobody → Kyle Mestery (mestery)
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/96555

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/96555
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b5d596877f538a84e8336b45026b552df8e53be6
Submitter: Jenkins
Branch: master

commit b5d596877f538a84e8336b45026b552df8e53be6
Author: Kyle Mestery <email address hidden>
Date: Thu May 29 13:07:55 2014 +0000

    Handle errors from run_ofctl() when dumping flows

    The function dump_flows_for_table() calls run_ofctl(). If this occurs during an OVS
    restart, run_ofctl() will return None. dump_flows_for_table() needs to realize this
    and not try to call splitlines() on a None object.

    Change-Id: Ide26028656e634113f955dfc89569149d4d5b306
    Closes-Bug: #1324659

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/96920

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/96920
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2b42dd3eabcfe337b701a88e9008aaa9d5f7b523
Submitter: Jenkins
Branch: stable/icehouse

commit 2b42dd3eabcfe337b701a88e9008aaa9d5f7b523
Author: Kyle Mestery <email address hidden>
Date: Thu May 29 13:07:55 2014 +0000

    Handle errors from run_ofctl() when dumping flows

    The function dump_flows_for_table() calls run_ofctl(). If this occurs during an OVS
    restart, run_ofctl() will return None. dump_flows_for_table() needs to realize this
    and not try to call splitlines() on a None object.

    Change-Id: Ide26028656e634113f955dfc89569149d4d5b306
    Closes-Bug: #1324659
    (cherry picked from commit b5d596877f538a84e8336b45026b552df8e53be6)

Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.