The header autopilot helper will fail if the parent is not called MainView
Bug #1324556 reported by
Leo Arias
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UI Toolkit |
Fix Released
|
Undecided
|
Leo Arias | ||
| gallery-app |
Invalid
|
Undecided
|
Leo Arias | ||
| gallery-app (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Bug Description
On the header autopilot helper we are assuming that the container is called MainView. There are many applications that extend the MainView component and it gets a new name. We should use a different way to get the parent without knowing the name.
Related branches
lp:~elopio/gallery-app/workaround1324556-get_header
- PS Jenkins bot: Approve (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 31 lines (+16/-2)1 file modifiedtests/autopilot/gallery_app/emulators/main_screen.py (+16/-2)
lp:~elopio/ubuntu-ui-toolkit/fix1324556-get_top_container
- PS Jenkins bot: Approve (continuous-integration)
- Ubuntu SDK team: Pending requested
-
Diff: 187 lines (+92/-26)6 files modifiedtests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_common.py (+16/-0)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_flickable.py (+0/-17)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_header.py (+2/-9)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/CustomMainView.qml (+23/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_header.HeaderInCustomMainViewTestCase.qml (+24/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_header.py (+27/-0)
- PS Jenkins bot: Pending (continuous-integration) requested
- Ubuntu SDK team: Pending requested
-
Diff: 354 lines (+210/-27)9 files modifiedmodules/Ubuntu/Components/PageStack.qml (+1/-0)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_common.py (+16/-0)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_flickable.py (+0/-17)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_header.py (+2/-9)
tests/autopilot/ubuntuuitoolkit/fixture_setup.py (+45/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/CustomMainView.qml (+23/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_header.HeaderInCustomMainViewTestCase.qml (+24/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_header.py (+27/-0)
tests/autopilot/ubuntuuitoolkit/tests/test_fixture_setup.py (+72/-1)
- Ubuntu SDK team: Pending requested
-
Diff: 619 lines (+219/-98)17 files modifiedCHANGES (+1/-1)
components.api (+7/-14)
modules/Ubuntu/Components/AnimatedItem.qml (+1/-38)
modules/Ubuntu/Components/ListItems/Base.qml (+1/-1)
modules/Ubuntu/Components/PageStack.qml (+1/-0)
modules/Ubuntu/Components/Pickers/DatePicker.qml (+4/-2)
modules/Ubuntu/Components/plugin/i18n.cpp (+6/-5)
modules/Ubuntu/Components/plugin/thumbnailgenerator.cpp (+6/-3)
modules/Ubuntu/Components/qmldir (+1/-2)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_common.py (+16/-0)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_flickable.py (+0/-17)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_header.py (+2/-9)
tests/autopilot/ubuntuuitoolkit/fixture_setup.py (+45/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_header.HeaderInCustomMainViewTestCase.qml (+27/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_header.py (+23/-0)
tests/autopilot/ubuntuuitoolkit/tests/test_fixture_setup.py (+72/-1)
tests/qmlapicheck.py (+6/-5)
| Changed in ubuntu-ui-toolkit: | |
| status: | New → In Progress |
| assignee: | nobody → Leo Arias (elopio) |
| Changed in gallery-app: | |
| status: | New → In Progress |
| assignee: | nobody → Leo Arias (elopio) |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in gallery-app (Ubuntu): | |
| status: | New → Confirmed |
| Changed in ubuntu-ui-toolkit: | |
| status: | In Progress → Fix Released |
| Changed in gallery-app: | |
| status: | In Progress → Invalid |
| Changed in gallery-app (Ubuntu): | |
| status: | Confirmed → Invalid |
To post a comment you must log in.
Status changed to 'Confirmed' because the bug affects multiple users.