Tiles not showing for libosmgpsmap 0.7.3

Bug #1320359 reported by Ruben Undheim
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
osm-gps-map (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
Fix Released
Undecided
Unassigned
Utopic
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
* The bug is really that libosmgpsmap does not follow OpenStreetMap's policy for accessing the tiles. The HTTP User-Agent must be valid. Therefore, OpenStreetMap has blocked access, and libosmpsmap is therefore unusable in many cases. It has been fixed upstream and is therefore also fixed in the proposed version for Utopic.

* A consequence of the bug is that programs such as "gpxviewer" (available via universe/misc) simply does not display any map.

* The fix should be backported to a stable release because Ubuntu users will not be able to use programs such as gpxviewer properly in Trusty (and Saucy and Precise) if it is not fixed.

* The fix changes the User-Agent to "libosmgpsmap/0.7.3" so that OpenStreetMap's tile server can see what is really downloading the tiles. The fix also makes it possible to build the package from source (FTBFS #1312890).

[Test Case]
* Install gpxviewer: apt-get install gpxviewer
* Run "gpxviwer". Zoom in on the map. If the map does not update, the bug is present - if it does update, the bug has been fixed!

[Regression Potential]
* Very small fix, so low regression risk
* Since the fix also fixes the FTBFS problem, it should be tested well to see that all the files earlier present in the binary package (built last in quantal) still are present.

[Original description]
The current version of libosmgpsmap (osm-gps-map) uses a "wrong" user-agent when querying tiles from tile.openstreetmap.org. This leads to no map shown. This has been fixed upstream and reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745860

This bug report contains a patch for fixing it in Ubuntu Trusty and it would be good to get it in.

Related branches

tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in osm-gps-map (Ubuntu):
status: New → Confirmed
Revision history for this message
Ross Gammon (rosco2) wrote :

Hi Ruben,

Thanks very much for the patch.

I might be willing to try and get the patch uploaded (via a sponsor). But first, could you please tell me how you are using the osm-gps-map library so that I can do a proper test? Do you use another application (e.g. gpxviewer/creepy/subsurface)?

Regards,

Ross

Changed in osm-gps-map (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Ruben Undheim (saltmakrell) wrote :

Hi Ross,

Thank you very much for showing interest.

One of the ways to show the problem is to simply compile the example application bundled with the
libosmgpsmap-dev package. The map will not appear in the GUI unless you change the
map source in the code (or apply the patch to the library)

To build the example, run:

gunzip -c /usr/share/doc/libosmgpsmap-dev/examples/mapviewer.ui.gz > mapviewer.ui
gunzip -c /usr/share/doc/libosmgpsmap-dev/examples/mapviewer.c.gz > mapviewer.c
gcc -o mapviewer mapviewer.c `pkg-config --cflags --libs glib-2.0` `pkg-config --cflags --libs gtk+-2.0` -pthread -I/usr/include/osmgpsmap -I/usr/include/gtk-2.0 -I/usr/include/libsoup-2.4 -I/usr/lib/i386-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/harfbuzz -I/usr/include/libxml2 -losmgpsmap -lgtk-x11-2.0 -lsoup-2.4 -lgdk-x11-2.0 -latk-1.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo -lpango-1.0 -lfontconfig -lfreetype -lgio-2.0 -lgobject-2.0 -lglib-2.0 `pkg-config --cflags --libs gthread-2.0`

Other than that, I've only been using gnuais together with osm-gps-map. Bear in mind however that in the latest version of gnuais, there is a workaround which hides this problem (the map source has been changed).

Regards,
Ruben

Revision history for this message
Ruben Undheim (saltmakrell) wrote :

I would also like to mention that I'm not able to build osm-gps-map if I just do:
apt-get source osm-gps-map
cd osm-gps-map-0.7.3
dpkg-buildpackage

It must be built in a pbuilder jail - then it works fine.
For some reason, it didn't work to build it in a launchpad PPA either. I'm not able to explain why. (https://launchpad.net/~saltmakrell/+archive/ppa/+build/6016949)

Ruben

Revision history for this message
Ruben Undheim (saltmakrell) wrote :

I've now fixed the "failed-to-build-from-source"-problem with this source package. I've tried to create a bzr branch which contains the fix (lp:~saltmakrell/launchpad/fixtiles-osm-gps-map) and it compiles correctly in my PPA on both i386 and amd64. Can someone help me getting this into trusty (and saucy)? It would be nice to have a usable libosmgpsmap.

Revision history for this message
Ross Gammon (rosco2) wrote : Re: [Bug 1320359] Re: Tiles not showing for libosmgpsmap 0.7.3

On 06/16/2014 12:35 AM, Ruben Undheim wrote:
> I've now fixed the "failed-to-build-from-source"-problem with this
> source package. I've tried to create a bzr branch which contains the fix
> (lp:~saltmakrell/launchpad/fixtiles-osm-gps-map) and it compiles
> correctly in my PPA on both i386 and amd64. Can someone help me getting
> this into trusty (and saucy)? It would be nice to have a usable
> libosmgpsmap.
>
Hi Ruben,

You have beaten me to it (I have been busy the last few weeks). Well
done - I can see that it builds okay now. I have not tested the updating
tiles though.

Now you need to follow the Stable Release Updates (SRU) process to make
a justification (and risk assessment) to include the fix in the stable
release:
https://wiki.ubuntu.com/StableReleaseUpdates

You will need a sponsor. I just went through the process on another
package. And if I can do it, I am sure you can!

Your sponsor may ask you to make some changes. Possibly, you might be
requested to split the two patches into two separate updates. But I
would go with what you have got and see what they say.

I can also see that your changelog entry needs a little tweak:
* Fixing "failing to build from source (FTBFS)"
* Fix for tiles not showing (Closes: #745860)

You need to reference the bug number for the FTBFS as well. Also, the
"(Closes: #bugnumber)" is for automatically closing Debian Bugs. For
Ubuntu, you should reference the Launchpad with "(LP: #bugnumber)".

Let me know if you need any help at any step of the way. I will also be
happy to do a test when you get to the verification stage.

Thanks for you work.

Ross

Revision history for this message
Ross Gammon (rosco2) wrote :

Sorry, maybe you were not aware that there was a FTBFS bug reported already:
https://bugs.launchpad.net/ubuntu/+source/osm-gps-map/+bug/1312890
Your patch closes both this bug and that one.

Revision history for this message
Ruben Undheim (saltmakrell) wrote :

Hi Ross,

Thanks a lot for explaining me what to do ! I'll make a try.

Ruben

Ross Gammon (rosco2)
Changed in osm-gps-map (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Ruben Undheim (saltmakrell) wrote :

I deleted the patch from this bug-report since this bzr branch should take care of it: https://code.launchpad.net/~saltmakrell/ubuntu/trusty/osm-gps-map/fixtiles-osm-gps-map
..and I don't want to keep them both of them updated.

Revision history for this message
Ross Gammon (rosco2) wrote :

Version 1.0.2-1 of osmgpsmap in Utopic contains the fix that Ruben is preparing for an SRU to Trusty.

Changed in osm-gps-map (Ubuntu):
status: Confirmed → Fix Released
description: updated
Revision history for this message
Ruben Undheim (saltmakrell) wrote :

I need a sponsor for this SRU candidate. The fix has been prepared as a bzr branch with a merge proposal. I've tried to get someone to nominate the bug via #ubuntu-bugs, but I haven't got any response (after 3 days). Maybe I'm doing something wrong?

Robie Basak (racb)
Changed in osm-gps-map (Ubuntu Trusty):
status: New → Triaged
Revision history for this message
Ruben Undheim (saltmakrell) wrote :

Version 1.0.2-1 has been backported from utopic to trusty (#1336889). However, it is still important to get 0.7.3 fixed for the packages that depend on it and GTK 2.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

The branch looks good to me. Assigned ubuntu-sru and will upload the package to trusty-proposed.

Revision history for this message
Sebastien Bacher (seb128) wrote :

(unsbuscribing sponsors, that got uploaded and is in the SRU queue waiting for review, http://launchpadlibrarian.net/179991478/osm-gps-map_0.7.3-3ubuntu1_source.changes)

Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Ruben, or anyone else affected,

Accepted osm-gps-map into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/osm-gps-map/0.7.3-3ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in osm-gps-map (Ubuntu Trusty):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Ruben Undheim (saltmakrell) wrote :

Thanks for uploading it to trusty-proposed! I've now verified that the version available in the proposed-repository works as expected (fixes the problem).

Revision history for this message
Brian Murray (brian-murray) wrote :

I've also verified that the version from trusty-proposed works. Setting the tag to verification-done per SRU procedure.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Ross Gammon (rosco2) wrote :

I can also confirm that after installing python-osmgpsmap from trusy-proposed, and then installing gpxviewer, I can zoom in on the map and scroll it around. The tiles are now updating.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package osm-gps-map - 0.7.3-3ubuntu1

---------------
osm-gps-map (0.7.3-3ubuntu1) trusty; urgency=low

  * Fixing "failing to build from source (FTBFS)" (LP: #1312890)
  * Fix for invalid user-agent (LP: #1320359)
 -- Ruben Undheim <email address hidden> Thu, 19 Jun 2014 17:22:23 +0200

Changed in osm-gps-map (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of the Stable Release Update for osm-gps-map has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in osm-gps-map (Ubuntu):
status: Fix Released → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Ruben, or anyone else affected,

Accepted osm-gps-map into utopic-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/osm-gps-map/0.7.3-3ubuntu1.14.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in osm-gps-map (Ubuntu Utopic):
status: New → Fix Committed
tags: removed: verification-done
tags: added: verification-needed
Revision history for this message
Ruben Undheim (saltmakrell) wrote :

The package in utopic-proposed fixes this. (verified)

tags: added: verification-done
removed: verification-needed
Chris J Arges (arges)
Changed in osm-gps-map (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package osm-gps-map - 0.7.3-3ubuntu1.14.10.1

---------------
osm-gps-map (0.7.3-3ubuntu1.14.10.1) utopic; urgency=low

  [ Ruben Undheim ]
  * Fixing "failing to build from source (FTBFS)" (LP: #1312890)
  * Fix for invalid user-agent (LP: #1320359)

  [ Dmitry Shachnev ]
  * Copy the trusty-updates version to Utopic (LP: #1388219).
 -- Ruben Undheim <email address hidden> Wed, 12 Nov 2014 18:17:58 +0200

Changed in osm-gps-map (Ubuntu Utopic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.