Additional drivers tab crashes if locale is sv and recommended driver available

A query has been forwarded to the mailinglist for translators too, about updates trickling down https://lists.ubuntu.com/archives/ubuntu-translators/2014-May/thread.html
There should really be a warning for translators - do not translate.( I dont see any point in translating it partially (testad)).

Well, my point is that '{licence}' - as it is inside braces, is the name of a text string used to carry either "open source" or "proprietary" depending on the conditions met, while 'tested' is a text that can be translated. But things like this may not be obvious to the translator if he/she don't recognize python syntax, leaving room for errors like this. So there should be a note to translators about this. But even better would be to change the source code to something like this:

SoftwarePropertiesGtk.py, line1276

   base_string = "{base_description} ({licence}, " + _("tested)")

This way the translator would only have to translate "tested)"

But what i really don't get is line 1278

   base_string = _("{base_description} ({licence})")

There is nothing that may be translated on that line so it should really be:

   base_string = "{base_description} ({licence})"

Status changed to 'Confirmed' because the bug affects multiple users.

A few notes to answer some of the questions:

- The original string is correctly marked for translation. The reason all arguments are marked for translation is so that languages that need to do so rearrange these arguments in a way that is readable for users.
- Mistranslation of one of the arguments is something gettext should have caught. I know gettext supports error checking using {} formatting strings (albeit since relatively recently), so I'm a bit puzzled as to why it didn't issue a warning in Launchpad. Perhaps LP is running on an Ubuntu version that does not yet include the latest gettext?

As for the fix:
- For Ubuntu 14.10 we're setting up translations and language packs, so it should be fixed automatically shortly
- For Ubuntu 14.04 we're now setting up a schedule [1] for language pack updates and should be fixed there shortly
- For Ubuntu 13.10, we'll need to release an on-demand language pack update.

So looking at the translations exports for 13.10, it seems the latest delta [1] includes the fix already, so we could pick up that file and prepare an SRU, or generate saucy langpacks for sv in the PPA and release that.

/rosetta-saucy/sv/LC_MESSAGES/software-properties.po

#: ../softwareproperties/gtk/SoftwarePropertiesGtk.py:1274
msgid "{base_description} ({licence}, tested)"
msgstr "{base_description} ({licence}, tested)"

[1] http://launchpadlibrarian.net/176039093/ubuntu-saucy-translations-update.tar.gz

"The original string is correctly marked for translation. The reason all arguments are marked for translation is so that languages that need to do so rearrange these arguments in a way that is readable for users."

Ah, that makes sense. Didn't think about that :)

Regarding gettext not catching the errors, I would say there is a chance similar bugs like this one may be out there. Somebody ought to take a look at that.

David Planella wrote:
> The original string is correctly marked for translation. The reason
> all arguments are marked for translation is so that languages that
> need to do so rearrange these arguments in a way that is readable for
> users.

Well, if that's the reason for gettexting it all, I think that line 1276 in SoftwarePropertiesGtk.py ought to be:

base_string = _("%s (%s, tested)") % ("{base_description}", "{licence}")

which would result in

msgid "%s (%s, tested)"

That way the risk for mistakes as the one described in this bug report would be eliminated, but the translators would still be able to reorder the arguments.

This is fixed in the language-pack-sv package in trusty-proposed. Please test and double-check that it works now. Thanks!

We didn't yet get an utopic langpack export from LP, but once we do this will get fixed in Utopic as well.

I uploaded language-pack-sv 13.10+20131012ubuntu1 to saucy-proposed which updates to the latest translations and also fixes this crash. Can you please test and confirm that it works now? Thanks!

@Martin: Even if the immediate issue is about to be fixed, I think there is room for improvement of the software-properties code (comment #7), so I add back a software-properties task.

Gunnar Hjalmarsson [2014-06-02 10:40 -0000]:
> @Martin: Even if the immediate issue is about to be fixed, I think there
> is room for improvement of the software-properties code (comment #7), so
> I add back a software-properties task.

Agreed, thanks.

Installed language-pack-sv 1:13.10+20131012ubuntu1 from saucy-proposed
and can confirm that it fixes the issue in this report.

As regards language-pack-sv in trusty-proposed, it was also successfully
tested as reported at
https://wiki.ubuntu.com/Translations/LanguagePackUpdatesQA

I installed language-pack-sv 1:14.04+20140522 from trusty proposed and can confirm that it fixes the issue on trusty as well.

This bug was fixed in the package language-pack-sv - 1:13.10+20131012ubuntu1

---------------
language-pack-sv (1:13.10+20131012ubuntu1) saucy-proposed; urgency=medium

  * Add current software-properties translations to fix the "{licence} →
    {license}" crash and get some updated translations. (LP: #1319257)
 -- Martin Pitt <email address hidden> Mon, 02 Jun 2014 10:27:41 +0200

The verification of the Stable Release Update for language-pack-sv has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Trusty update copied as well.

Fixed in Utopic with language-pack-sv 1:14.10+20140605.

Shouldnt this bug be closed, fix commited a long time ago