utils.calm() calms only spheres and clumps

Bug #1318513 reported by Jan Stránský
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Yade
Fix Released
Low
Unassigned

Bug Description

Fix is very easy, I just wanted to know opinion of other devs (e.g. if there is a reason I missed)

Jan Stránský (honzik)
summary: - utils.caml() calms only spheres and clumps
+ utils.calm() calms only spheres and clumps
Revision history for this message
Bruno Chareyre (bruno-chareyre) wrote :

I don't see a real reason to not calm other shapes.
It may have unpleasant side effects to calm everything, like overwriting the velocity defined by the boundary control of rigid boundaries. But if this is a big deall the user can define his own calm function.

Revision history for this message
Anton Gladky (gladky-anton) wrote : Re: [Bug 1318513] Re: utils.calm() calms only spheres and clumps

I agree with that.

Anton

2014-05-12 9:58 GMT+02:00 Bruno Chareyre <email address hidden>:
> I don't see a real reason to not calm other shapes.

Revision history for this message
Jan Stránský (honzik) wrote :

Hi Bruno,
this also came to my mind, but one if somebody prescribe a bc for spheres,
current calm function overwrite it anyway.. The function skip non-dynamic
bodies.
Thanks
Jan

2014-05-12 9:58 GMT+02:00 Bruno Chareyre <email address hidden>:

> I don't see a real reason to not calm other shapes.
> It may have unpleasant side effects to calm everything, like overwriting
> the velocity defined by the boundary control of rigid boundaries. But if
> this is a big deall the user can define his own calm function.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1318513
>
> Title:
> utils.calm() calms only spheres and clumps
>
> Status in Yet Another Dynamic Engine:
> New
>
> Bug description:
> Fix is very easy, I just wanted to know opinion of other devs (e.g. if
> there is a reason I missed)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/yade/+bug/1318513/+subscriptions
>

Revision history for this message
Christian Jakob (jakob-ifgt) wrote :

Hi,

I implemented calm() and used it as alternative "damping" method (e.g. when using a small local damping in a sim.).

From this discussion I can see, that an update is needed for this method.

An easy way could be to introduce an includeBodyList (or an excludeBodyList).
example:

includeList = []

for b in O.bodies:
  if CONDITION:
    includeList.append(b.id)

calm(includeList)

Revision history for this message
Anton Gladky (gladky-anton) wrote :

Well, we have mask-parameter there, which is also relatively
flexible. But includeList is also a good idea and will probably
be even faster.

Anton

2014-05-12 11:18 GMT+02:00 Christian Jakob <email address hidden>:
> Hi,
>
> I implemented calm() and used it as alternative "damping" method (e.g.
> when using a small local damping in a sim.).
>
> >From this discussion I can see, that an update is needed for this
> method.
>
> An easy way could be to introduce an includeBodyList (or an excludeBodyList).
> example:
>
> includeList = []
>
> for b in O.bodies:
> if CONDITION:
> includeList.append(b.id)
>
> calm(includeList)

Revision history for this message
Jan Stránský (honzik) wrote :

Ok, I will think about it and implement something in 2 weeks. If you wanted
to do something earlier, feel free to modify it.
cheers
Jan

2014-05-12 11:30 GMT+02:00 Anton Gladky <email address hidden>:

> Well, we have mask-parameter there, which is also relatively
> flexible. But includeList is also a good idea and will probably
> be even faster.
>
> Anton
>
>
> 2014-05-12 11:18 GMT+02:00 Christian Jakob <email address hidden>:
> > Hi,
> >
> > I implemented calm() and used it as alternative "damping" method (e.g.
> > when using a small local damping in a sim.).
> >
> > >From this discussion I can see, that an update is needed for this
> > method.
> >
> > An easy way could be to introduce an includeBodyList (or an
> excludeBodyList).
> > example:
> >
> > includeList = []
> >
> > for b in O.bodies:
> > if CONDITION:
> > includeList.append(b.id)
> >
> > calm(includeList)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1318513
>
> Title:
> utils.calm() calms only spheres and clumps
>
> Status in Yet Another Dynamic Engine:
> New
>
> Bug description:
> Fix is very easy, I just wanted to know opinion of other devs (e.g. if
> there is a reason I missed)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/yade/+bug/1318513/+subscriptions
>

Revision history for this message
Jan Stránský (honzik) wrote :

I left mask parameter for the purpose of slecting bodies to calm and
modified documentation of the function (the original version mentioned,
that the function calms all bodies, which was the source of my confusion).
Thanks for discussion
Jan

2014-05-12 12:06 GMT+02:00 Jan Stránský <email address hidden>:

> Ok, I will think about it and implement something in 2 weeks. If you
> wanted to do something earlier, feel free to modify it.
> cheers
> Jan
>
>
> 2014-05-12 11:30 GMT+02:00 Anton Gladky <email address hidden>:
>
> Well, we have mask-parameter there, which is also relatively
>> flexible. But includeList is also a good idea and will probably
>> be even faster.
>>
>> Anton
>>
>>
>> 2014-05-12 11:18 GMT+02:00 Christian Jakob <email address hidden>:
>> > Hi,
>> >
>> > I implemented calm() and used it as alternative "damping" method (e.g.
>> > when using a small local damping in a sim.).
>> >
>> > >From this discussion I can see, that an update is needed for this
>> > method.
>> >
>> > An easy way could be to introduce an includeBodyList (or an
>> excludeBodyList).
>> > example:
>> >
>> > includeList = []
>> >
>> > for b in O.bodies:
>> > if CONDITION:
>> > includeList.append(b.id)
>> >
>> > calm(includeList)
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1318513
>>
>> Title:
>> utils.calm() calms only spheres and clumps
>>
>> Status in Yet Another Dynamic Engine:
>> New
>>
>> Bug description:
>> Fix is very easy, I just wanted to know opinion of other devs (e.g. if
>> there is a reason I missed)
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/yade/+bug/1318513/+subscriptions
>>
>
>

Changed in yade:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.