Python code should conform to pep8 and pyflakes
Bug #1317198 reported by
Nicholas Skaggs
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Dropping Letters |
Fix Released
|
Medium
|
Alan Pope πΊπ§π± π¦ | ||
| Stock Ticker App |
Fix Released
|
Medium
|
Alan Pope πΊπ§π± π¦ | ||
| Sudoku App |
Fix Released
|
Medium
|
Alan Pope πΊπ§π± π¦ | ||
| Ubuntu Clock App |
Fix Released
|
Medium
|
Nekhelesh Ramananthan | ||
| Ubuntu Document Viewer App |
Fix Released
|
Medium
|
Alan Pope πΊπ§π± π¦ | ||
| Ubuntu Shorts App |
Fix Released
|
Medium
|
Alan Pope πΊπ§π± π¦ | ||
| Ubuntu Terminal App |
Fix Released
|
Medium
|
Alan Pope πΊπ§π± π¦ | ||
| Ubuntu Weather App |
Fix Released
|
Medium
|
Nekhelesh Ramananthan | ||
Bug Description
The core apps autopilot tests which are written in python should conform to pep8 and pass pyflakes as well as a minimum standard for readable, maintainable code. The affected apps don't yet conform to these standards and do not have jenkins hooks to enforce them on merge.
To fix, a merge proposal should be created to fix all current issues raise by pep8 and pyflakes. Then the jenkins hook for pep8 and pyflakes should be added to the merge jobs for the core app.
Related branches
lp:~nik90/ubuntu-clock-app/fix-pep8-errors
- PS Jenkins bot: Approve (continuous-integration)
- Nicholas Skaggs (community): Approve
- Ubuntu Phone Apps Jenkins Bot: Needs Fixing (continuous-integration)
-
Diff: 57 lines (+10/-9)2 files modifiedtests/autopilot/ubuntu_clock_app/emulators.py (+2/-1)
tests/autopilot/ubuntu_clock_app/tests/test_alarm.py (+8/-8)
lp:~nik90/ubuntu-weather-app/fix-pep8-errors
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Nicholas Skaggs: Pending requested
-
Diff: 976 lines (+308/-156)5 files modifiedtests/autopilot/ubuntu_weather_app/emulators.py (+2/-0)
tests/autopilot/ubuntu_weather_app/tests/__init__.py (+15/-10)
tests/autopilot/ubuntu_weather_app/tests/test_locationmanager.py (+69/-33)
tests/autopilot/ubuntu_weather_app/tests/test_mainview.py (+55/-24)
tests/autopilot/ubuntu_weather_app/tests/test_settings.py (+167/-89)
lp:~popey/sudoku-app/fix-1317198
- Nicholas Skaggs (community): Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 14 lines (+2/-2)1 file modifiedtests/autopilot/sudoku_app/tests/test_sudoku.py (+2/-2)
lp:~popey/stock-ticker-mobile-app/fix-1317198
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Stock Ticker Developers: Pending requested
-
Diff: 23 lines (+2/-3)2 files modifiedtests/autopilot/stock_ticker/emulators.py (+0/-2)
tests/autopilot/stock_ticker/tests/__init__.py (+2/-1)
lp:~popey/ubuntu-docviewer-app/fix-1317198
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Ubuntu Document Viewer Developers: Pending requested
-
Diff: 68 lines (+4/-12)2 files modifiedtests/autopilot/ubuntu_docviewer_app/tests/__init__.py (+2/-7)
tests/autopilot/ubuntu_docviewer_app/tests/test_docviewer.py (+2/-5)
lp:~popey/ubuntu-terminal-app/fix-1317198
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Ubuntu Terminal Developers: Pending requested
-
Diff: 188 lines (+49/-37)2 files modifiedtests/autopilot/ubuntu_terminal_app/emulators.py (+16/-11)
tests/autopilot/ubuntu_terminal_app/tests/test_terminal.py (+33/-26)
lp:~popey/ubuntu-rssreader-app/fix-1317198
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Ubuntu Shorts Developers: Pending requested
-
Diff: 177 lines (+42/-34)1 file modifiedtests/autopilot/shorts_app/tests/test_rssreader.py (+42/-34)
| Changed in dropping-letters: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in stock-ticker-mobile-app: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in sudoku-app: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in ubuntu-clock-app: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in ubuntu-docviewer-app: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in ubuntu-rssreader-app: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in ubuntu-terminal-app: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in ubuntu-weather-app: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in dropping-letters: | |
| assignee: | nobody → Alan Pope γ (popey) |
| Changed in stock-ticker-mobile-app: | |
| assignee: | nobody → Alan Pope γ (popey) |
| Changed in sudoku-app: | |
| assignee: | nobody → Alan Pope γ (popey) |
| Changed in ubuntu-clock-app: | |
| assignee: | nobody → Alan Pope γ (popey) |
| Changed in ubuntu-docviewer-app: | |
| assignee: | nobody → Alan Pope γ (popey) |
| Changed in ubuntu-rssreader-app: | |
| assignee: | nobody → Alan Pope γ (popey) |
| Changed in ubuntu-terminal-app: | |
| assignee: | nobody → Alan Pope γ (popey) |
| Changed in ubuntu-weather-app: | |
| assignee: | nobody → Alan Pope γ (popey) |
| Changed in ubuntu-clock-app: | |
| assignee: | Alan Pope γ (popey) → Nekhelesh Ramananthan (nik90) |
| status: | Confirmed → In Progress |
| Changed in ubuntu-weather-app: | |
| status: | Confirmed → In Progress |
| assignee: | Alan Pope γ (popey) → Nekhelesh Ramananthan (nik90) |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #1 |
| Changed in ubuntu-weather-app: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Alan Pope πΊπ§π± π¦ (popey) wrote | #2 |
| Changed in dropping-letters: | |
| status: | Confirmed → Fix Released |
| Changed in sudoku-app: | |
| status: | Confirmed → Fix Committed |
| Changed in stock-ticker-mobile-app: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #3 |
| Changed in ubuntu-docviewer-app: | |
| status: | Confirmed → In Progress |
| Changed in ubuntu-docviewer-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-terminal-app: | |
| status: | Confirmed → Fix Committed |
| Changed in ubuntu-rssreader-app: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #4 |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #5 |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #6 |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #7 |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #8 |
| Changed in ubuntu-clock-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-terminal-app: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-weather-app: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-rssreader-app: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-docviewer-app: | |
| status: | Fix Committed → Fix Released |
| Changed in sudoku-app: | |
| status: | Fix Committed → Fix Released |
| Changed in stock-ticker-mobile-app: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-clock-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-weather-app at revision 254, scheduled for release in ubuntu-weather-app, milestone alpha-1