Image URLs aren't resolved correctly if they begin with a double slash
Bug #1311626 reported by
Michael Sheldon
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
webbrowser-app |
Fix Released
|
Undecided
|
Michael Sheldon | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
URLs beginning with "//" should inherit the parent document's protocol, however when using the context menu to open an image in a new tab or copy an image URL an incorrect URL is provided. Currently it treats these URLs as if they began with a single / and adds the parent document's domain to the URL.
Steps to reproduce:
1. Visit http://
2. Long press on an image
3. Select open new tab
Expect result:
Image should open in new tab
Actual result:
404 due to incorrect URL being generated
Related branches
lp:~michael-sheldon/webbrowser-app/fix-double-slash-image-urls
- Olivier Tilloy: Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 37 lines (+14/-2)2 files modifiedsrc/Ubuntu/Components/Extras/Browser/selection01.js (+7/-1)
src/Ubuntu/Components/Extras/Browser/selection02.js (+7/-1)
Changed in webbrowser-app: | |
assignee: | nobody → Michael Sheldon (michael-sheldon) |
Changed in webbrowser-app: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+14. 10.20140505. 1-0ubuntu1
--------------- 10.20140505. 1-0ubuntu1) utopic; urgency=low
webbrowser-app (0.23+14.
[ Michael Sheldon ]
* Resolve image URLs beginning with a double slash correctly for
context menu items (LP: #1311626)
[ Adnane Belmadiaf ]
* Enabled passwordEchoEnabled (LP: #1314251)
[ Alberto Mardegan ] ntext, which is a WebContext derivative with the UA Context, which is a singleton
* Split UbuntuWebContext into two different components:
UbuntuWebCo
overrides for Ubuntu. UbuntuSharedWeb
for UbuntuWebContext .
[ Olivier Tilloy ]
* Build the models in a separate static lib, and link the unit tests
against it. This speeds up build time by avoiding having to
recompile the models’ source for each unit test.
* Handle javascript console messages.
* Escape literal dots in UA override matching regular expressions.
* Enable localStorage by default in the browser. (LP: #1309673)
* Ensure that the URL actually changes so that the address bar is
updated in case the user has entered a new address that redirects to
where she previously was. (LP: #1306615)
* Update bzr ignore rules.
-- Ubuntu daily release <email address hidden> Mon, 05 May 2014 20:47:19 +0000