Rewrite charm/add unit tests coverage/ expose nova_logs configuration option.
Bug #1310793 reported by
Jorge Niedbalski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| rsyslog (Juju Charms Collection) |
Fix Released
|
Undecided
|
Jorge Niedbalski | ||
Bug Description
[Description]
rsyslog charm saves all collected logs to one concatenated file. Users wants that this charm provides a way to separate syslog file into hostname based files or component based files.
[Solution]
I rewrote the whole charm to use the python charmhelpers. Also this charm lacks of unit tests to validate the hooks code, i added several test cases for covering the hooks.
[Additional]
Openstack document for loggging configuration:
http://
Related branches
lp:~niedbalski/charms/precise/rsyslog/lp-1310793
- Marco Ceppi (community): Approve
-
Diff: 1813 lines (+1595/-70)24 files modifiedMakefile (+22/-0)
README (+0/-1)
charm-helpers.yaml (+5/-0)
config.yaml (+4/-0)
files/60-aggregator.conf (+0/-7)
hooks/charmhelpers/contrib/templating/contexts.py (+104/-0)
hooks/charmhelpers/core/hookenv.py (+401/-0)
hooks/charmhelpers/core/host.py (+297/-0)
hooks/charmhelpers/fetch/__init__.py (+308/-0)
hooks/charmhelpers/fetch/archiveurl.py (+63/-0)
hooks/charmhelpers/fetch/bzrurl.py (+49/-0)
hooks/config-changed (+0/-39)
hooks/hooks.py (+125/-0)
hooks/install (+0/-8)
hooks/start (+0/-8)
hooks/stop (+0/-4)
hooks/upgrade-charm (+0/-2)
revision (+1/-1)
setup.cfg (+5/-0)
templates/60-aggregator.conf (+7/-0)
templates/nova-logging.conf (+12/-0)
templates/rsyslog.conf (+37/-0)
test_requirements.txt (+6/-0)
unit_tests/test_hooks.py (+149/-0)
| Changed in rsyslog (Juju Charms Collection): | |
| status: | New → In Progress |
| assignee: | nobody → Jorge Niedbalski (niedbalski) |
| summary: |
- Expose nova_split_logging_templates directive + Add unit tests coverage/expose nova_logs configuration option. |
| description: | updated |
| summary: |
- Add unit tests coverage/expose nova_logs configuration option. + Rewrite charm/add unit tests coverage/ expose nova_logs configuration + option. |
| Changed in rsyslog (Juju Charms Collection): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Proposed merge request https:/