[SRU] Mugshot fails to expand user details

Bug #1310634 reported by Hoy Tampoco
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mugshot
Fix Released
High
Unassigned
mugshot (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
New
Undecided
Unassigned

Bug Description

[Impact]
For some users, Mugshot may fail to start because it was unable to expand
user details from /etc/passwd. This was fixed in the following revision,
in Mugshot 0.2.4:
https://bazaar.launchpad.net/~mugshot-dev/mugshot/trunk/revision/122

This fix avoids the following fatal startup error.

Traceback (most recent call last):
  File "/usr/bin/mugshot", line 35, in <module>
    mugshot.main()
  File "/usr/lib/python3/dist-packages/mugshot/__init__.py", line 45, in main
    window = MugshotWindow.MugshotWindow()
  File "/usr/lib/python3/dist-packages/mugshot_lib/Window.py", line 50, in __new__
    new_object.finish_initializing(builder)
  File "/usr/lib/python3/dist-packages/mugshot/MugshotWindow.py", line 217, in finish_initializing
    self.init_user_details()
  File "/usr/lib/python3/dist-packages/mugshot/MugshotWindow.py", line 247, in init_user_details
    name, office, office_phone, home_phone = details.split(',', 3)
ValueError: need more than 1 value to unpack

[Test Case]
1. Set your account name to "A".
2. Clear any other contact details from /etc/passwd (using chfn)
3. Start Mugshot.

[Expected Results]
Mugshot should start successfully.

[Regression Potential]
None. This release pads the account details so that this scenario is no longer possible.

Related branches

Sean Davis (bluesabre)
description: updated
Revision history for this message
Sean Davis (bluesabre) wrote :

I've fixed this and will include it in the next release.

Changed in mugshot:
status: New → Fix Committed
Sean Davis (bluesabre)
Changed in mugshot:
importance: Undecided → High
Sean Davis (bluesabre)
Changed in mugshot:
milestone: none → 0.2.4
Sean Davis (bluesabre)
Changed in mugshot:
status: Fix Committed → Fix Released
Sean Davis (bluesabre)
summary: - Mugshot doesn' start (Xubuntu 14.04)
+ [SRU] Mugshot fails to expand user details
description: updated
Changed in mugshot (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.