CKEditor does not load on trusty

Bug #1309133 reported by Gediminas Paulauskas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SchoolTool
Fix Released
Critical
Gediminas Paulauskas
schooltool (Ubuntu)
Fix Released
Medium
Gediminas Paulauskas
Trusty
Fix Released
Medium
Unassigned

Bug Description

In trusty, CKEditor is version 4.3 instead of 3.6.x that we supported.

When loading a page that requires ckeditor, it is not loaded, and an error is printed to console:

Uncaught TypeError: Cannot read property 'add' of undefined

in localhost:7080/@@/schooltool.skin.flourish-ckeditor/skin.js?t=DAED:6

CKEDITOR.skins property is removed (http://docs.ckeditor.com/#!/guide/dev_api_changes)

Changed in schooltool (Ubuntu):
assignee: nobody → Gediminas Paulauskas (menesis)
Changed in schooltool (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote : Missing SRU information

Thanks for uploading the fix for this bug report to -proposed. However, when reviewing the package in -proposed and the details of this bug report I noticed that the bug description is missing information required for the SRU process. You can find full details at http://wiki.ubuntu.com/StableReleaseUpdates#Procedure but essentially this bug is missing some of the following: a statement of impact, a test case and details regarding the regression potential. Thanks in advance!

Revision history for this message
Gediminas Paulauskas (menesis) wrote :

The fix for trusty is in SchoolTool PPA https://launchpad.net/~schooltool-owners/+archive/ppa/

I will push it to stable updates with a new upstream release.

Other Ubuntu releases are not affected since they have an older ckeditor.

Changed in schooltool (Ubuntu):
status: Fix Committed → Fix Released
milestone: none → ubuntu-14.04.1
Changed in schooltool:
status: New → Fix Committed
importance: Undecided → Critical
assignee: nobody → Gediminas Paulauskas (menesis)
milestone: none → 2.6.4
Revision history for this message
Brian Murray (brian-murray) wrote :

Being released in a PPA doesn't make the bug task Fix Released for Ubuntu.

Changed in schooltool (Ubuntu):
status: Fix Released → In Progress
Revision history for this message
Brian Murray (brian-murray) wrote :

Maybe you meant to make the SchooTool task Fix Released?

Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Gediminas, or anyone else affected,

Accepted schooltool into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/schooltool/1:2.6.3-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in schooltool (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed
Changed in schooltool:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package schooltool - 1:2.6.4-0ubuntu2

---------------
schooltool (1:2.6.4-0ubuntu2) utopic; urgency=low

  * Upload to utopic.
 -- Gediminas Paulauskas <email address hidden> Mon, 05 May 2014 23:26:29 +0300

Changed in schooltool (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Mathew Hodson (mhodson) wrote :

Fixed in Trusty with http://launchpad.net/ubuntu/+source/schooltool/1:2.6.3-0ubuntu2

Tested with Firefox 29.0 on the page /persons/manager/calendar/add.html. The editor loads, and the TypeError is not shown in the console.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package schooltool - 1:2.6.3-0ubuntu2

---------------
schooltool (1:2.6.3-0ubuntu2) trusty; urgency=medium

  * debian/patches/ckeditor4.patch: make compatible with CKEditor 4.x
    (LP: #1309133)
 -- Gediminas Paulauskas <email address hidden> Thu, 17 Apr 2014 20:58:15 +0300

Changed in schooltool (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of the Stable Release Update for schooltool has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Mathew Hodson (mhodson)
Changed in schooltool (Ubuntu):
importance: Critical → Medium
Changed in schooltool (Ubuntu Trusty):
importance: Undecided → Medium
milestone: none → trusty-updates
Changed in schooltool (Ubuntu):
milestone: ubuntu-14.04.1 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.