juju scp no longer allows multiple extra arguments to pass through
Bug #1306208 reported by
John A Meinel
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-core |
Fix Released
|
High
|
John A Meinel | ||
| 1.18 |
Fix Released
|
Critical
|
John A Meinel | ||
| juju-core (Ubuntu) |
Fix Released
|
Critical
|
Unassigned | ||
| Trusty |
Fix Released
|
Critical
|
Unassigned | ||
Bug Description
We changed 'juju scp' to allow for multiple targets (juju scp a b c 0:foo, or juju scp 0:foo 0:bar .), however that broke support for passing multiple arguments directly to scp (juju scp -o SetX -o SetY 0:foo .)
IMO we should just look at each argument, match it against a regex that would match "0:" or "unit/0:" and then expand any argument that matches, and pass everything else through.
I think this is actually a regression in 'juju scp' functionality, so it should be considered important for a .1 release of 1.18.
Related branches
lp:~jameinel/juju-core/1.18-scp-multiple-args-1306208
- Ian Booth: Approve
-
Diff: 398 lines (+158/-79)7 files modifiedcmd/juju/scp.go (+35/-35)
cmd/juju/scp_test.go (+100/-27)
utils/ssh/ssh.go (+3/-3)
utils/ssh/ssh_gocrypto.go (+1/-1)
utils/ssh/ssh_gocrypto_test.go (+1/-1)
utils/ssh/ssh_openssh.go (+5/-6)
utils/ssh/ssh_test.go (+13/-6)
lp:~wallyworld/juju-core/1.18-scp-multiple-args-1306208
- Juju Engineering: Pending requested
-
Diff: 411 lines (+159/-80)8 files modifiedcmd/juju/scp.go (+35/-35)
cmd/juju/scp_test.go (+100/-27)
cmd/plugins/juju-restore/restore.go (+1/-1)
utils/ssh/ssh.go (+3/-3)
utils/ssh/ssh_gocrypto.go (+1/-1)
utils/ssh/ssh_gocrypto_test.go (+1/-1)
utils/ssh/ssh_openssh.go (+5/-6)
utils/ssh/ssh_test.go (+13/-6)
lp:~wallyworld/juju-core/port-1.18-2267-2268
- Juju Engineering: Pending requested
-
Diff: 614 lines (+269/-113)11 files modifiedcmd/juju/scp.go (+35/-35)
cmd/juju/scp_test.go (+115/-30)
cmd/plugins/juju-restore/restore.go (+1/-1)
utils/ssh/ssh.go (+3/-3)
utils/ssh/ssh_gocrypto.go (+1/-1)
utils/ssh/ssh_gocrypto_test.go (+1/-1)
utils/ssh/ssh_openssh.go (+5/-6)
utils/ssh/ssh_test.go (+13/-6)
worker/upgrader/export_test.go (+4/-1)
worker/upgrader/upgrader.go (+40/-28)
worker/upgrader/upgrader_test.go (+51/-1)
| Changed in juju-core: | |
| assignee: | nobody → John A Meinel (jameinel) |
| status: | Triaged → In Progress |
| Changed in juju-core: | |
| milestone: | 1.18.1 → 1.19.1 |
| Changed in juju-core: | |
| status: | In Progress → Fix Committed |
| Changed in juju-core: | |
| milestone: | 1.19.1 → 1.19.0 |
| Changed in juju-core (Ubuntu Trusty): | |
| importance: | Undecided → Critical |
| status: | New → Triaged |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in juju-core (Ubuntu Trusty): | |
| status: | Triaged → Fix Released |
| Changed in juju-core: | |
| importance: | Critical → High |
| Changed in juju-core: | |
| status: | Fix Committed → Fix Released |
| summary: |
- juju scp no longer allows multiple extra arguments to pass throug + juju scp no longer allows multiple extra arguments to pass through |
To post a comment you must log in.
This bug was fixed in the package juju-core - 1.18.1-0ubuntu1
---------------
juju-core (1.18.1-0ubuntu1) trusty; urgency=medium
* New upstream point release, including fixes for:
- Upgrading juju 1.16.6 -> 1.18.x fails (LP: #1299802).
- Peer relation disappears during juju-upgrade (LP: #1303697).
- public-address of units changes to internal bridge post upgrade
(LP: #1303735).
- Unable to deploy local charms without series (LP: #1303880).
- juju scp no longer allows multiple extra arguments to be passed
(LP: #1306208).
- juju cannot downgrade to same major.minor version with earlier
patch number (LP: #1306296).
-- James Page <email address hidden> Sat, 12 Apr 2014 07:04:37 +0100