[snapdecision.pinlock] show three lines of text
Bug #1303680 reported by
Antti Kaijanmäki
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Network Menu |
Fix Released
|
Undecided
|
Antti Kaijanmäki | ||
| unity8 (Ubuntu) |
Fix Released
|
Undecided
|
Michael Zanetti | ||
Bug Description
An extra text field to allow showing three lines of text in the dialog. This might be possible to handle with the body text if it supports line break and text formatting (varying text size). Maybe some shiny colors as well!
This is needed in a Multi-SIM situation where we have to show additional info such as the IMSI or Phonenumber if the SIM beign unlcoked + the attempt counter.
Related branches
lp:~mzanetti/unity8/lockscreen-enhancements
- PS Jenkins bot (community): Approve (continuous-integration)
- Antti Kaijanmäki (community): Approve
-
Diff: 749 lines (+342/-56)6 files modifiedqml/Components/PinPadButton.qml (+2/-1)
qml/Greeter/Lockscreen.qml (+91/-7)
qml/Greeter/PassphraseLockscreen.qml (+6/-2)
qml/Greeter/PinLockscreen.qml (+29/-11)
qml/Shell.qml (+2/-1)
tests/qmltests/Greeter/tst_Lockscreen.qml (+212/-34)
lp:~unity-api-team/indicator-network/dual_sim_pin_unlock
- Olga Kemmet (community): Approve (design)
- Michael Zanetti (community): Abstain
- PS Jenkins bot (community): Approve (continuous-integration)
- Charles Kerr (community): Approve
-
Diff: 899 lines (+329/-183)9 files modifiedpo/indicator-network.pot (+116/-76)
src/indicator/modem-manager.cpp (+3/-4)
src/indicator/modem.cpp (+2/-2)
src/indicator/sim-unlock-dialog.cpp (+139/-71)
src/indicator/sim-unlock-dialog.h (+1/-0)
src/menumodel-cpp/gio-helpers/variant.h (+28/-0)
src/notify-cpp/snapdecision/sim-unlock.cpp (+38/-28)
src/notify-cpp/snapdecision/sim-unlock.h (+1/-1)
tests/autopilot/indicator_network/data/pin-unlock.xml (+1/-1)
| Changed in unity8: | |
| assignee: | nobody → Antti Kaijanmäki (kaijanmaki) |
| Changed in unity8: | |
| assignee: | Antti Kaijanmäki (kaijanmaki) → Michael Zanetti (mzanetti) |
| Changed in indicator-network: | |
| assignee: | nobody → Antti Kaijanmäki (kaijanmaki) |
| Changed in unity8: | |
| status: | New → In Progress |
| Changed in unity8: | |
| status: | In Progress → Fix Released |
| Changed in indicator-network: | |
| status: | New → In Progress |
| Changed in indicator-network: | |
| status: | In Progress → Fix Released |
| affects: | unity8 → unity8 (Ubuntu) |
To post a comment you must log in.
