[Greeter] [PIN lock] modal info dialog on top of the unlock UI
Bug #1303635 reported by
Antti Kaijanmäki
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Network Menu |
Fix Released
|
Undecided
|
Antti Kaijanmäki | ||
| Ubuntu UX |
Fix Released
|
Undecided
|
Olga Kemmet | ||
| unity8 (Ubuntu) |
Fix Released
|
Undecided
|
Michael Zanetti | ||
Bug Description
W need to add a way to overlay yet another modal dialog on top of the simunlock UI to tell the user "You have only 1 attempt left until [your PIN code is locked | until your SIM card gets permanently blocked].
Related branches
lp:~mzanetti/unity8/lockscreen-enhancements
- PS Jenkins bot (community): Approve (continuous-integration)
- Antti Kaijanmäki (community): Approve
-
Diff: 749 lines (+342/-56)6 files modifiedqml/Components/PinPadButton.qml (+2/-1)
qml/Greeter/Lockscreen.qml (+91/-7)
qml/Greeter/PassphraseLockscreen.qml (+6/-2)
qml/Greeter/PinLockscreen.qml (+29/-11)
qml/Shell.qml (+2/-1)
tests/qmltests/Greeter/tst_Lockscreen.qml (+212/-34)
lp:~unity-api-team/indicator-network/dual_sim_pin_unlock
- Olga Kemmet (community): Approve (design)
- Michael Zanetti (community): Abstain
- PS Jenkins bot (community): Approve (continuous-integration)
- Charles Kerr (community): Approve
-
Diff: 899 lines (+329/-183)9 files modifiedpo/indicator-network.pot (+116/-76)
src/indicator/modem-manager.cpp (+3/-4)
src/indicator/modem.cpp (+2/-2)
src/indicator/sim-unlock-dialog.cpp (+139/-71)
src/indicator/sim-unlock-dialog.h (+1/-0)
src/menumodel-cpp/gio-helpers/variant.h (+28/-0)
src/notify-cpp/snapdecision/sim-unlock.cpp (+38/-28)
src/notify-cpp/snapdecision/sim-unlock.h (+1/-1)
tests/autopilot/indicator_network/data/pin-unlock.xml (+1/-1)
| Changed in unity8: | |
| assignee: | nobody → Antti Kaijanmäki (kaijanmaki) |
Revision history for this message
| Michał Sawicz (saviq) wrote | #1 |
Revision history for this message
| Michael Zanetti (mzanetti) wrote | #2 |
Revision history for this message
| Antti Kaijanmäki (kaijanmaki) wrote | #3 |
Revision history for this message
| Antti Kaijanmäki (kaijanmaki) wrote | #4 |
| Changed in indicator-network: | |
| assignee: | nobody → Antti Kaijanmäki (kaijanmaki) |
| Changed in unity8: | |
| assignee: | Antti Kaijanmäki (kaijanmaki) → Michael Zanetti (mzanetti) |
| Changed in unity8: | |
| status: | New → In Progress |
| Changed in unity8: | |
| status: | In Progress → Fix Released |
| Changed in ubuntu-ux: | |
| assignee: | nobody → Matthew Paul Thomas (mpt) |
| Changed in ubuntu-ux: | |
| assignee: | Matthew Paul Thomas (mpt) → Olga Kemmet (olga-kemmet) |
| status: | New → Fix Released |
| summary: |
- [snapdecision.pinlock] modal info dialog on top of the unlock UI + [Greeter] [PIN lock] modal info dialog on top of the unlock UI |
| Changed in indicator-network: | |
| status: | New → In Progress |
| Changed in indicator-network: | |
| status: | In Progress → Fix Released |
| affects: | unity8 → unity8 (Ubuntu) |
To post a comment you must log in.
I feel like this should actually be part of the SIM PIN dialog, not a layer on top of it.