instance: NewAddress{,es} is a footgun

Bug #1298770 reported by Dave Cheney
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
Dave Cheney

Bug Description

instance.NewAddress{,es} only creates Address values of scope NetworkUnknown.

Apparently this is only used as a helper in tests, not in the code.

I think instance.NewAddress should be moved to a testing package, or deleted altogether as Addreses of scope NetworkUnknown are valid both as Public and Private addresses, and this is absolutely not what people want.

Tags: tech-debt

Related branches

Changed in juju-core:
assignee: nobody → Dave Cheney (dave-cheney)
milestone: none → changelog.txt
status: New → In Progress
milestone: changelog.txt → none
importance: Undecided → Medium
Changed in juju-core:
milestone: none → changelog.txt
Changed in juju-core:
milestone: changelog.txt → 1.18.0
importance: Medium → High
Changed in juju-core:
milestone: 1.18.0 → changelog.txt
Changed in juju-core:
milestone: changelog.txt → 1.18.0
Changed in juju-core:
milestone: 1.18.0 → changelog.txt
Changed in juju-core:
milestone: changelog.txt → 1.17.8
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 1.17.8 → 1.19.0
Curtis Hovey (sinzui)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.