instance: NewAddress{,es} is a footgun
Bug #1298770 reported by
Dave Cheney
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
High
|
Dave Cheney |
Bug Description
instance.
Apparently this is only used as a helper in tests, not in the code.
I think instance.NewAddress should be moved to a testing package, or deleted altogether as Addreses of scope NetworkUnknown are valid both as Public and Private addresses, and this is absolutely not what people want.
Related branches
lp:~dave-cheney/juju-core/107-new-addresses-take-varargs
- Juju Engineering: Pending requested
-
Diff: 126 lines (+10/-11)9 files modifiedinstance/address.go (+1/-1)
instance/address_test.go (+2/-3)
state/api/deployer/deployer_test.go (+1/-1)
state/api/machiner/machiner_test.go (+1/-1)
state/api/provisioner/provisioner_test.go (+1/-1)
state/megawatcher_internal_test.go (+1/-1)
worker/instancepoller/aggregate_test.go (+1/-1)
worker/peergrouper/mock_test.go (+1/-1)
worker/peergrouper/worker_test.go (+1/-1)
lp:~dave-cheney/juju-core/108-set-addresses-take-varargs
- Juju Engineering: Pending requested
-
Diff: 461 lines (+43/-65)23 files modifiedcmd/juju/scp_test.go (+1/-1)
cmd/juju/ssh_test.go (+1/-1)
cmd/juju/status_test.go (+1/-1)
cmd/jujud/machine_test.go (+1/-1)
juju/testing/utils.go (+1/-3)
state/api/deployer/deployer_test.go (+2/-5)
state/api/machiner/machiner_test.go (+1/-1)
state/api/provisioner/provisioner_test.go (+2/-4)
state/apiserver/client/client_test.go (+6/-6)
state/apiserver/client/run_test.go (+2/-2)
state/apiserver/deployer/deployer_test.go (+2/-6)
state/apiserver/uniter/uniter_test.go (+1/-3)
state/machine.go (+1/-1)
state/machine_test.go (+1/-1)
state/megawatcher_internal_test.go (+1/-2)
state/state_test.go (+5/-5)
state/unit_test.go (+5/-7)
worker/instancepoller/machine_test.go (+1/-1)
worker/instancepoller/updater.go (+2/-2)
worker/provisioner/kvm-broker_test.go (+1/-3)
worker/provisioner/lxc-broker_test.go (+1/-3)
worker/provisioner/provisioner_test.go (+1/-3)
worker/uniter/uniter_test.go (+3/-3)
lp:~dave-cheney/juju-core/106-add-scope-to-instance-new-address
- Juju Engineering: Pending requested
-
Diff: 998 lines (+127/-126)33 files modifiedcmd/juju/ssh_test.go (+1/-2)
cmd/juju/status_test.go (+36/-36)
cmd/jujud/machine_test.go (+2/-2)
environs/manual/addresses_test.go (+3/-3)
instance/address.go (+8/-5)
instance/address_test.go (+19/-13)
juju/apiconn_test.go (+1/-1)
juju/testing/utils.go (+1/-1)
provider/common/bootstrap_test.go (+3/-3)
provider/joyent/instance.go (+1/-1)
provider/maas/instance_test.go (+2/-2)
state/api/deployer/deployer_test.go (+2/-2)
state/api/machiner/machiner_test.go (+3/-3)
state/api/provisioner/provisioner_test.go (+2/-2)
state/api/testing/apiaddresser.go (+3/-3)
state/apiserver/client/client_test.go (+7/-13)
state/apiserver/client/run_test.go (+2/-2)
state/apiserver/deployer/deployer_test.go (+2/-2)
state/apiserver/login_test.go (+1/-1)
state/apiserver/machine/machiner_test.go (+2/-2)
state/apiserver/uniter/uniter_test.go (+1/-1)
state/machine_test.go (+4/-4)
state/megawatcher_internal_test.go (+1/-1)
state/state_test.go (+1/-1)
state/statecmd/machineconfig_test.go (+2/-2)
state/unit_test.go (+4/-8)
worker/instancepoller/machine_test.go (+1/-1)
worker/instancepoller/worker_test.go (+1/-3)
worker/machiner/machiner.go (+6/-1)
worker/machiner/machiner_test.go (+2/-2)
worker/provisioner/kvm-broker_test.go (+1/-1)
worker/provisioner/lxc-broker_test.go (+1/-1)
worker/provisioner/provisioner_test.go (+1/-1)
Changed in juju-core: | |
assignee: | nobody → Dave Cheney (dave-cheney) |
milestone: | none → changelog.txt |
status: | New → In Progress |
milestone: | changelog.txt → none |
importance: | Undecided → Medium |
Changed in juju-core: | |
milestone: | none → changelog.txt |
Changed in juju-core: | |
milestone: | changelog.txt → 1.18.0 |
importance: | Medium → High |
Changed in juju-core: | |
milestone: | 1.18.0 → changelog.txt |
Changed in juju-core: | |
milestone: | changelog.txt → 1.18.0 |
Changed in juju-core: | |
milestone: | 1.18.0 → changelog.txt |
Changed in juju-core: | |
milestone: | changelog.txt → 1.17.8 |
Changed in juju-core: | |
milestone: | 1.17.8 → 1.19.0 |
Changed in juju-core: | |
status: | In Progress → Fix Committed |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.