Ubuntu UI Toolkit

flaky UbuntuListView unit tests with x86 build of Qt5.2

Bug #1288597 reported by Zsombor Egri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
Critical
Michael Zanetti
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Unit tests for UbuntuListView are flaky. They seem to pass on armhf and amd64, but fail on i386.

Executing ./tst_components -input tst_ubuntulistview.qml -maxwarnings 20 -o ../../test_tst_ubuntulistview.qml.xml,xunitxml -o -,txt
process 23009: D-Bus library appears to be incorrectly set up; failed to read machine uuid: Failed to open "/etc/machine-id": No such file or directory
See the manual page for dbus-uuidgen to correct this issue.
********* Start testing of components *********
Config: Using QtTest library 5.2.1, Qt 5.2.1
PASS : components::UbuntuListView::initTestCase()
FAIL! : components::UbuntuListView::test_collapseByClickingOutside() property expanded
   Actual (): true
   Expected (): false
   Loc: [/build/buildd/ubuntu-ui-toolkit-0.1.46+14.04.20140304+fixdatepicker/tests/unit_x11/tst_components/tst_ubuntulistview.qml(153)]
PASS : components::UbuntuListView::test_destroyAndRecreateExpanded()
PASS : components::UbuntuListView::test_dimOthers()
PASS : components::UbuntuListView::test_expandedItem()
FAIL! : components::UbuntuListView::test_noScrollingNeeded() Compared values are not the same with delta(0.5)
   Actual (): -271.952066115703
   Expected (): 48
   Loc: [/build/buildd/ubuntu-ui-toolkit-0.1.46+14.04.20140304+fixdatepicker/tests/unit_x11/tst_components/tst_ubuntulistview.qml(119)]
PASS : components::UbuntuListView::test_scrollIntoView()
FAIL! : components::UbuntuListView::test_scrollToTop() Compared values are not the same with delta(0.5)
   Actual (): -95.9520661157026
   Expected (): 0
   Loc: [/build/buildd/ubuntu-ui-toolkit-0.1.46+14.04.20140304+fixdatepicker/tests/unit_x11/tst_components/tst_ubuntulistview.qml(131)]
PASS : components::UbuntuListView::cleanupTestCase()
Totals: 6 passed, 3 failed, 0 skipped

Tags: qt5.2

Related branches

lp:~mzanetti/ubuntu-ui-toolkit/more-stable-ubuntulistview-tests
Tim Peeters: Approve
Zsombor Egri: Approve
Timo Jyrinki: Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 19 lines (+2/-0)
1 file modified
tests/unit_x11/tst_components/tst_ubuntulistview.qml (+2/-0)
lp:ubuntu/trusty-proposed/ubuntu-ui-toolkit
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

A workaround in use currently is to disable the tests https://code.launchpad.net/~timo-jyrinki/ubuntu-system-settings/rebuild_against_qt521/+merge/209587

Changed in ubuntu-ui-toolkit:
status: New → Confirmed
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Correction: https://code.launchpad.net/~timo-jyrinki/ubuntu-ui-toolkit/exclude_tests_to_get_x86_to_pass/+merge/209586 - two test files disabled.

Michael Zanetti (mzanetti)
Changed in ubuntu-ui-toolkit:
status: Confirmed → In Progress
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Fixed with the new branch in the landing PPA:
https://launchpad.net/~ci-train-ppa-service/+archive/landing-006/+sourcepub/3958525/+listing-archive-extra

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Revision history for this message
Tim Peeters (tpeeters) wrote :

Looks like the same bug is present with Qt 5.0.2. I just got this when running 'make check' for a branch that I'm working on (unrelated to UbuntuListView):

********* Start testing of components *********
Config: Using QTest library 5.0.2, Qt 5.0.2
PASS : components::UbuntuListView::initTestCase()
PASS : components::UbuntuListView::test_collapseByClickingOutside()
PASS : components::UbuntuListView::test_destroyAndRecreateExpanded()
PASS : components::UbuntuListView::test_dimOthers()
PASS : components::UbuntuListView::test_expandedItem()
FAIL! : components::UbuntuListView::test_noScrollingNeeded() Compared values are not the same with delta(0.5)
   Actual (): -272.084628099174
   Expected (): 48
   Loc: [/home/tim/dev/ubuntu-ui-toolkit/tabsModelIndex/tests/unit_x11/tst_components/tst_ubuntulistview.qml(119)]
PASS : components::UbuntuListView::test_scrollIntoView()
FAIL! : components::UbuntuListView::test_scrollToTop() Compared values are not the same with delta(0.5)
   Actual (): -96.0846280991736
   Expected (): 0
   Loc: [/home/tim/dev/ubuntu-ui-toolkit/tabsModelIndex/tests/unit_x11/tst_components/tst_ubuntulistview.qml(131)]
PASS : components::UbuntuListView::cleanupTestCase()
Totals: 7 passed, 2 failed, 0 skipped
********* Finished testing of components *********

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Fix is in landing-006 PPA, ready to be copied to the archives.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 0.1.46+14.04.20140306.1-0ubuntu1

---------------
ubuntu-ui-toolkit (0.1.46+14.04.20140306.1-0ubuntu1) trusty; urgency=low

  [ Zsombor Egri ]
  * DatePicker flaky test fix. (LP: #1287009)

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Michael Zanetti ]
  * Make the UbuntuListView tests more stable (LP: #1288597)
 -- Ubuntu daily release <email address hidden> Thu, 06 Mar 2014 12:46:50 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Fix Committed → Fix Released
Timo Jyrinki (timo-jyrinki)
Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.