Answering "No" to the replace file prompt closes the save dialog

Bug #12880 reported by Marius Gedminas
18
Affects Status Importance Assigned to Milestone
firefox (Ubuntu)
Fix Released
Low
David Farning

Bug Description

This problem applies only to recent Firefox versions what use the Gtk+ file chooser.

When you accidentaly try to save a file with the name of an already existing
file, you get a confirmation dialog (file exists, do you want to overwrite it).
 If you answer "no", the save dialog is closed and you are not given a chance to
enter another name.

To reproduce:

1. Open any web page in Firefox
2. Hit Ctrl+S
3. Save the page
4. Hit Ctrl+S again
5. Try to save the file again with the same name.
6. You will get a "File already exists, do you want to replace it?" dialog.
7. Click on "No"

The save dialog disappears.

Expected result: the save dialog would remain and let me enter a different file
name.

Revision history for this message
Uphaar Agrawalla (uphaar) wrote :

Also, the "No" button (which is the default action) appears to the left of the
"Yes" button here.

The default action should be on the right side, according to the HIG:

http://developer.gnome.org/projects/gup/hig/2.0/windows-alert.html#alert-button-order

Revision history for this message
levander (levander) wrote :

Just upgraded to the latest version of Firefox in the ubuntu repositories this
morning.

I've got another problem with replacing files that you've already downloaded.
When I download files from sourceforge a second time, the auto-renaming feature
gives the downloaded file a wierd name. For example, if you download
javaapp-1.0.jar, the 1.0 usually refers to the version number of the javaapp
jar. However, if you download this file a 2nd time, firefox is renaming the
file to javaapp-2.0.jar. This is really a bad renaming scheme for me as I end
up downloading a lot of jar files and rely on the jar filename to know the
version of the jar. Here is a link you can download from once, wait for it to
complete downloading, then download a 2nd time to see the new filename:

http://easynews.dl.sourceforge.net/sourceforge/jpox/jdo-2.0-snapshot.jar

Revision history for this message
Thom May (thombot) wrote :

(In reply to comment #2)
> Just upgraded to the latest version of Firefox in the ubuntu repositories this
> morning.
>
> I've got another problem with replacing files that you've already downloaded.
> When I download files from sourceforge a second time, the auto-renaming feature
> gives the downloaded file a wierd name. For example, if you download
> javaapp-1.0.jar, the 1.0 usually refers to the version number of the javaapp
> jar. However, if you download this file a 2nd time, firefox is renaming the
> file to javaapp-2.0.jar. This is really a bad renaming scheme for me as I end
> up downloading a lot of jar files and rely on the jar filename to know the
> version of the jar. Here is a link you can download from once, wait for it to
> complete downloading, then download a 2nd time to see the new filename:
>
> http://easynews.dl.sourceforge.net/sourceforge/jpox/jdo-2.0-snapshot.jar

Please, please please, don't conflate bug reports. This is two bug reports :-)

Revision history for this message
Ian Jackson (ijackson) wrote :

I can reproduce the original problem and that described in comment #2. I agree
with the submitter. However, I think these issues would best be addressed upstream.

Revision history for this message
David Farning (dfarning) wrote :

Created an attachment (id=4717)
ubuntu save as

Revision history for this message
David Farning (dfarning) wrote :

Created an attachment (id=4718)
upstream save as

Revision history for this message
David Farning (dfarning) wrote :

The ubuntu save as dialog is different then the upstream save as dialog. see
prior attachments. Upstream works as expected.

Revision history for this message
Dennis Kaarsemaker (dennis) wrote :

Has anybody tested this with 1.5 already?

Revision history for this message
Alexandre Otto Strube (surak) wrote :

There are three bugs in this post:

The original, which states that anwsering no closes the save dialog;

The first comment, from Uphaar Agrawalla, which states that the dialog is not HID compliant (this have it own bug)

The second comment, from levander, about a renaming scheme. there a launchpad bug for this already open. Just to let you know.

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Ok, I confirm this bug with firefox 1.5. Please discuss other issues in other bug reports.

There is two patchs available, someone to review them ?

Changed in firefox:
status: Unconfirmed → Confirmed
Ian Jackson (ijackson)
Changed in firefox:
assignee: ijackson → nobody
Revision history for this message
David Farning (dfarning) wrote :

The primary issue of this bug report has been fixed in edgy and feisty. If the user answers cancel to the overwrite dialog they are taken back to the save dialog with a option to rename the file.

David

Changed in firefox:
assignee: nobody → dfarning
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.