UbuntuUI.Toolbar Example Is Not Valid HTML

Bug #1286833 reported by JoshuaStrobl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu HTML5 UI SDK
Fix Released
Undecided
Adnane Belmadiaf
ubuntu-html5-theme (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

As the summary states, the UbuntuUI.Toolbar API in 14.04 SDK version (http://developer.ubuntu.com/api/html5/sdk-14.04/UbuntuUI.Toolbar/) has an example that has incorrect HTML. To be more precise, it has a <ul> unordered list tag after a nav tag, and the UL tag is closed off with a </div> tag with the </nav> inside.

Content of example:
 <footer data-role="footer" class="revealed" id="footerID">
   <nav>
     <ul>
       <li>
         <a href="#" id="home">Home</a>
       </li>
     </nav>
   </div>
 </footer>
 JavaScript access:
 var toolbar = UI.footer("footerID");
 UI.button('home').click(function () {
   UI.pagestack.push("main");
 });

Should be:
 <footer data-role="footer" class="revealed" id="footerID">
   <nav>
     <ul>
       <li>
         <a href="#" id="home">Home</a>
       </li>
      </ul>
    </nav>
 </footer>
 JavaScript access:
 var toolbar = UI.footer("footerID");
 UI.button('home').click(function () {
   UI.pagestack.push("main");
 });

Tags: docs

Related branches

Changed in ubuntudeveloperportal:
status: New → Invalid
Michael Hall (mhall119)
affects: ubuntudeveloperportal → ubuntu-html5-theme
Changed in ubuntu-html5-theme:
status: Invalid → Confirmed
Adnane Belmadiaf (daker)
Changed in ubuntu-html5-theme:
assignee: nobody → Adnane Belmadiaf (daker)
status: Confirmed → In Progress
Adnane Belmadiaf (daker)
tags: added: docs
David Barth (dbarth)
Changed in ubuntu-html5-theme (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-html5-theme - 0.1.2+14.04.20140404-0ubuntu1

---------------
ubuntu-html5-theme (0.1.2+14.04.20140404-0ubuntu1) trusty; urgency=low

  [ Alexandre Abreu ]
  * Connect qmlengine quit signal to app quit slot (LP: #1299563)
  * Fix issues with the toolbar buttons: make sure that we dont
    preventDefault() in all cases (even when the user tries to
    click()),. make sure that the user's intent seems like
    hiding/showing before doing so,. (LP: #1222874)

  [ Adnane Belmadiaf ]
  * Removed unused locales.json

  [ David Barth ]
  * This branch aggregates 3 branches to help resolve SASS/CSS conflicts
    on the same file: merge of fix.1286362. merge of typography-update.
    merge of the fix.gallery-dialog branch .

  [ daker ]
  * Fixed toolbar declaration (LP: #1286833)
  * Adjust the content when the keyboard appears (LP: #1296463)

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Kyle Nitzsche ]
  * 1) Fix lp bug https://bugs.launchpad.net/ubuntu-html5-
    theme/+bug/1241029 2) Improve doc building as follows: * add build
    script for docs: yuidoc-build.sh.(same as in unity-webapps-qml) *
    add docslib.py, used by yuidoc-build.sh to obtain bzr branch rev and
    insert it into yuidoc.json for use during build * add
    DOCSREADMET.txt: critical info about building docs * yuidoc.json:
    add majorversion field and set it to current framework: html-14.04-
    dev. The bzr branch rev is appended to this to create useful version
    field, which is consumed by yuidoc build and inserted into built
    html. As a result, the built index.html states the framework and the
    branch bzr rev as follows: "API Docs for: HTML-14.04-dev~bzr155"
    (LP: #1287826)
 -- Ubuntu daily release <email address hidden> Fri, 04 Apr 2014 14:12:11 +0000

Changed in ubuntu-html5-theme (Ubuntu):
status: Fix Committed → Fix Released
Changed in ubuntu-html5-theme:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.