License text is tiny (Text widget not looking integrated)

Bug #1286262 reported by Matthew Paul Thomas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-system-settings (Ubuntu)
Fix Released
Low
Sebastien Bacher
ubuntu-ui-toolkit (Ubuntu)
Invalid
Low
Unassigned

Bug Description

Ubuntu Trusty r188

1. In System Settings, navigate to "About this phone" > "Software licenses".
2. Select any of the components.

What you see: License text in a tiny font.

What you should see: License text in the standard font for body text.

Related branches

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report, I can confirm that. We are using a standard Qt Text{} component there, I'm having a look at using TextArea{} from the Ubuntu toolkit instead

Changed in ubuntu-system-settings (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

If Qt's Text{} uses a too-small font by default, perhaps that should be fixed in the theme instead? We shouldn't have anything in the toolkit that produces undesirable results by default.

Revision history for this message
Tim Peeters (tpeeters) wrote :

For Ubuntu apps, we recommend to use Label { } which adds styling and ubuntu font sizes to Text, see http://developer.ubuntu.com/api/qml/sdk-14.04/Ubuntu.Components.Label/

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

In that case, I propose this is a toolkit bug. Following Rusty's levels of API design <http://sweng.the-davies.net/Home/rustys-api-design-manifesto>, this scores 3/10: "Read the documentation and you'll get it right."

If we themed Text{} to use the same style as Label{}, we'd improve to 7/10, "The obvious use is (probably) the correct one." Another possible solution would be to remove Text{} from the SDK altogether, though I guess that would be surprising to people who had used QtQuick before.

Revision history for this message
Zsombor Egri (zsombi) wrote :

I don't get this: "Another possible solution would be to remove Text{} from the SDK altogether,". Text is NOT an SDK component, it's a QtQuick one. So if someone uses Text instead of Label, the font properties the Label applies (fontFamily and fontSize) will not be applied at all. Thus bugs on Text should not bve filed for SDK/UITK.

Revision history for this message
Zsombor Egri (zsombi) wrote :

We simply cannot theme Text as it is not our component.

Changed in ubuntu-system-settings (Ubuntu):
status: Triaged → In Progress
summary: - License text is tiny
+ License text is tiny (Text widget not looking integrated)
Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Sebastien Bacher (seb128)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Invalid
importance: Undecided → Low
Revision history for this message
Sebastien Bacher (seb128) wrote :

Ok, fair enough. When I wrote that UI the toolkit documentation was less good than it is today, Label is well documented and recommended, let's consider that an early adopter issue and not a toolkit bug ;-)

Revision history for this message
Zsombor Egri (zsombi) wrote :

So, to be clear, if an app developer decides to use Text instead of Label, it is up to the developer to set the font and color properties to be in par with the UI.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Zsombor, I appreciate that your team has put a lot of work into implementing Ubuntu-specific components. But if it is possible for an Ubuntu app developer to use a QtQuick component without bundling it with their app, then QtQuick *is* de facto part of the Ubuntu toolkit, regardless of whether you think of it as "our component". It didn't appear in the system image by magic.

Now, if QtQuick is full of components that Ubuntu app developers shouldn't use, or that produce undesirable results by default, then that is a design flaw. It will repeatedly result in developers, many of them not as painstaking as Sebastien, :-) producing undesirable results. If the SDK team isn't responsible for fixing that, then who is?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.1+14.04.20140311-0ubuntu1

---------------
ubuntu-system-settings (0.1+14.04.20140311-0ubuntu1) trusty; urgency=low

  [ Sebastien Bacher ]
  * license: use Label widget instead of Text, it looks more integrated
    (LP: #1286262)
  * language: don't display an chevron for the language item, the list
    displayed is a sheet widget and not a page stack one. (lp: #1289287)
    (LP: #1289287)

  [ Iain Lane ]
  * background selector: lock the toolbar open, per the design (LP:
    #1288361)
  * Don't crash if the migration script can't set values (LP: #1288833)

  [ Michael Terry ]
  * Tweak some of the wording of the wizard, and start the language
    combo expanded

  [ CI bot ]
  * Resync trunk

  [ Omer Akram ]
  * autopilot tests code: fix pep8 and pyflakes warnings. add tests to
    make sure we don't regress on pep8/pyflakes .

  [ Didier Roche ]
  * switch to suru icon theme
 -- Ubuntu daily release <email address hidden> Tue, 11 Mar 2014 15:14:22 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.