s-i-dbus should exit on D-Bus method exceptions
Bug #1279970 reported by
Barry Warsaw
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu system image |
Fix Released
|
High
|
Barry Warsaw | ||
Bug Description
When an exception occurs in a D-Bus method or signal, dbus-python prints the traceback to stderr, but then swallows the exception, such that the D-Bus service does not exit. But in D-Bus activation, stderr output is lost for all intents an purposes. Better behavior for us would be to log the exception in the 'systemimage' log file and then exit the s-i-dbus process.
Along with this, I'd like to put more detailed D-Bus logging in a systemimage.dbus logger. This would log enter/exit/
Related branches
lp:~barry/ubuntu-system-image/citrain-24.0u1
- Ubuntu CI managed package branches: Pending requested
-
Diff: 2708 lines (+1013/-217)53 files modifiedNEWS.rst (+18/-0)
PKG-INFO (+1/-1)
cli-manpage.rst (+2/-9)
coverage.ini (+15/-0)
debian/changelog (+27/-0)
debian/control (+0/-1)
debian/rules (+4/-15)
debian/system-image-common.postinst (+2/-0)
debian/system-image-common.postrm (+2/-0)
ini-manpage.rst (+21/-6)
setup.cfg (+2/-2)
system_image.egg-info/PKG-INFO (+1/-1)
system_image.egg-info/SOURCES.txt (+6/-0)
systemimage/api.py (+1/-1)
systemimage/bag.py (+1/-1)
systemimage/bindings.py (+2/-2)
systemimage/candidates.py (+1/-1)
systemimage/channel.py (+1/-1)
systemimage/config.py (+17/-4)
systemimage/dbus.py (+77/-15)
systemimage/device.py (+1/-1)
systemimage/download.py (+6/-5)
systemimage/gpg.py (+2/-2)
systemimage/helpers.py (+25/-42)
systemimage/image.py (+1/-1)
systemimage/logging.py (+36/-34)
systemimage/main.py (+15/-9)
systemimage/reactor.py (+1/-1)
systemimage/reboot.py (+1/-1)
systemimage/scores.py (+1/-1)
systemimage/service.py (+9/-7)
systemimage/settings.py (+1/-1)
systemimage/state.py (+6/-0)
systemimage/testing/controller.py (+8/-4)
systemimage/testing/dbus.py (+71/-1)
systemimage/testing/helpers.py (+2/-1)
systemimage/testing/nose.py (+11/-3)
systemimage/testing/service.py (+50/-0)
systemimage/tests/data/channel_06.ini (+8/-0)
systemimage/tests/data/channel_07.ini (+8/-0)
systemimage/tests/data/config_03.ini (+1/-1)
systemimage/tests/data/config_09.ini (+27/-0)
systemimage/tests/data/config_10.ini (+35/-0)
systemimage/tests/test_api.py (+12/-0)
systemimage/tests/test_config.py (+63/-2)
systemimage/tests/test_dbus.py (+161/-10)
systemimage/tests/test_download.py (+45/-18)
systemimage/tests/test_helpers.py (+72/-4)
systemimage/tests/test_main.py (+32/-2)
systemimage/tests/test_state.py (+82/-2)
systemimage/version.txt (+1/-1)
tox.ini (+16/-2)
unittest.cfg (+2/-1)
| Changed in ubuntu-system-image: | |
| status: | New → Triaged |
| Changed in ubuntu-system-image: | |
| importance: | Undecided → Medium |
| Changed in ubuntu-system-image: | |
| importance: | Medium → Low |
Revision history for this message
| Barry Warsaw (barry) wrote | #1 |
| Changed in ubuntu-system-image: | |
| milestone: | none → 2.4 |
| status: | Triaged → In Progress |
| importance: | Low → High |
| summary: |
- Commit suicide earlier, when error case is detected + s-i-dbus should exit on D-Bus method exceptions |
| description: | updated |
| Changed in ubuntu-system-image: | |
| assignee: | nobody → Barry Warsaw (barry) |
| Changed in ubuntu-system-image: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Turns out, I really need this to properly test the fix for LP: #1365646 so I'm bumping the priority up and starting to work on it.