The qubuntu library is not compiled when packaging

Bug #1271464 reported by Albert Astals Cid
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qtubuntu (Ubuntu)
Fix Released
Critical
Ricardo Mendoza

Bug Description

The qtubuntu debian/rules tries to compile two packages, one for android with
  dh_auto_configure -- "CONFIG+=mirserver" "CONFIG+=mirclient" "CONFIG+=hybris" "QMAKE_CXXFLAGS=-g"
and one for desktop with
  dh_auto_configure -- "CONFIG+=mirserver" "CONFIG+=mirclient" "QMAKE_CXXFLAGS=-g"

But it seems that this does not work properly since if i run dpkg-buildpackage the resulting qtubuntu-android_0.53+14.04.20140114.1-0ubuntu1_amd64.deb does not contain the libqubuntu.so file

But if i remove the
       dh $@ --builddirectory=$(DESKTOP_DIR) --parallel
       mkdir -p $(DESKTOP_DIR) && dh_auto_configure -- "CONFIG+=mirserver" "CONFIG+=mirclient" "QMAKE_CXXFLAGS=-g" $(CURDIR)
lines from the debian/rules package the libqubuntu.so does indeed end up in qtubuntu-android_0.53+14.04.20140114.1-0ubuntu1_amd64.deb

Tags: patch

Related branches

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

If you just switch the lines in the other order, ie android lines come last, you get libqubuntu.so too.

With or without the patch, the binary platform plugin files in both qtubuntu-android and qtubuntu-desktop are bit identical at least on x86. Is that intended?

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Additionally, looking at the build log the actual builds happens only in the directory that was specified first, ie. build-android/ at the moment and build-desktop with the patch. So it does not look like it's actually doing any double building, but just copying the same files in two packages which have different dependencies.

Revision history for this message
Albert Astals Cid (aacid) wrote :

I'd say that libqubuntu.so has to end up in the -android package only and not in the -desktop one, but not sure about that to be honest.

Ricardo Mendoza (ricmm)
Changed in qtubuntu:
assignee: nobody → Ricardo Mendoza (ricmm)
status: New → In Progress
importance: Undecided → Critical
Revision history for this message
Stephen M. Webb (bregma) wrote :

My bad, I didn't realize debhelper does not support out-of-source builds for qmake projects. I'll try to get a fix up soon.

Changed in qtubuntu:
assignee: Ricardo Mendoza (ricmm) → Stephen M. Webb (bregma)
importance: Critical → High
status: In Progress → Triaged
Revision history for this message
Stephen M. Webb (bregma) wrote :

Sorry, mid-air collision.

Changed in qtubuntu:
assignee: Stephen M. Webb (bregma) → Ricardo Mendoza (ricmm)
importance: High → Critical
status: Triaged → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:qtubuntu at revision 202, scheduled for release in qtubuntu, milestone ubuntu-13.05

Changed in qtubuntu:
status: In Progress → Fix Committed
tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtubuntu - 0.53+14.04.20140131-0ubuntu1

---------------
qtubuntu (0.53+14.04.20140131-0ubuntu1) trusty; urgency=low

  [ CI bot ]
  * Flushing trunk

  [ Ricardo Mendoza ]
  * Clean up build rules to allow for correct building of multiple
    binary packages from the same source. (LP: #1271464)
 -- Ubuntu daily release <email address hidden> Fri, 31 Jan 2014 12:39:46 +0000

Changed in qtubuntu (Ubuntu):
status: New → Fix Released
Changed in qtubuntu:
status: Fix Committed → Fix Released
Michał Sawicz (saviq)
Changed in qtubuntu (Ubuntu):
assignee: nobody → Ricardo Mendoza (ricmm)
importance: Undecided → Critical
no longer affects: qtubuntu
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.