Autopilot tests (try to) stop maliit-server

Bug #1268640 reported by Olivier Tilloy
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu Calculator App
Fix Released
High
Unassigned
Ubuntu Calendar App
Fix Released
High
Unassigned
Ubuntu Clock App
Fix Released
High
Unassigned
Ubuntu File Manager App
Fix Released
High
Unassigned
Ubuntu Shorts App
Fix Released
High
Unassigned
Ubuntu Weather App
Fix Released
High
Unassigned

Bug Description

Since revision 168 in lp:ubuntu-calendar-app, the following code was added to the setUp() method of the base test case for autopilot calendar app tests:

        #turn off the OSK so it doesn't block screen elements
        if model() != 'Desktop':
            os.system("stop maliit-server")
            #adding cleanup step seems to restart service immeadiately
            #disabling for now
            #self.addCleanup(os.system("start maliit-server"))

This feels and looks wrong. If we prevent the OSK from appearing, then we’re not really testing the app in normal conditions, are we?
Besides, it simply doesn’t work when I try to run the tests on my Galaxy Nexus, all the tests fail.

Finally, the commented out cleanup doesn’t work because addCleanup expects a function object, not a call. So it should be something like: self.addCleanup(lambda: os.system("start maliit-server")). But that’s an unimportant detail considering the points above. This should be removed, and the edit event test fixed in a proper way.

Related branches

Leo Arias (elopio)
Changed in ubuntu-calendar-app:
status: New → Confirmed
importance: Undecided → High
tags: added: elopio
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

This is not the only place this code is found.. Let's add the other affected apps. I should know, it's leftover hackiness from me. ::ducks::

Changed in ubuntu-calculator-app:
status: New → Confirmed
Changed in ubuntu-clock-app:
status: New → Confirmed
Changed in ubuntu-filemanager-app:
status: New → Confirmed
Changed in ubuntu-rssreader-app:
status: New → Confirmed
Changed in ubuntu-weather-app:
status: New → Confirmed
Changed in ubuntu-calculator-app:
importance: Undecided → High
Changed in ubuntu-clock-app:
importance: Undecided → High
Changed in ubuntu-filemanager-app:
importance: Undecided → High
Changed in ubuntu-rssreader-app:
importance: Undecided → High
Changed in ubuntu-weather-app:
importance: Undecided → High
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

The original purpose behind this was to solve a bug with the OSK blocking screen elements. These bugs may still exist, and due to how we test, we may yet be forced into a similar solution. Just a heads up when you are removing these.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

I've been converting the core apps over to cake (the ones Sergio didn't yet touch), and adding the tweak to at least stop not turning OSK back on.

Changed in ubuntu-filemanager-app:
status: Confirmed → Fix Released
Changed in ubuntu-calculator-app:
status: Confirmed → Fix Released
Changed in ubuntu-calendar-app:
status: Confirmed → Fix Released
Changed in ubuntu-weather-app:
status: Confirmed → Fix Released
Changed in ubuntu-clock-app:
status: Confirmed → Fix Released
Changed in ubuntu-rssreader-app:
status: Confirmed → Fix Released
tags: added: needs-autopilot-test
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.