Ubuntu Apps Directory

Import of sca apps fails

Bug #1267731 reported by Michael Nelson
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu Apps Directory
Fix Released
Medium
Michael Nelson

Bug Description

Haw reported a nagios alert [1] for apps.ubuntu.com, failing to import the sca apps:

$ tail /srv/uwc.ubuntu.com/production-logs/import-sca-apps-data.log
2014-01-10 00:00:12,356 - webcatalog.management.commands.import_sca_apps - INFO - Starting import of sca apps at https://software-center.ubuntu.com/api/2.0/applications/any/ubuntu/any/any/
UnboundLocalError: local variable 'app' referenced before assignment

Based on that, the bug is pretty obvious in import_sca_apps.py:Command.import_app_from_data ('app' is assigned only if the form validation passes, but returned either way).

[1] https://pastebin.canonical.com/102762/

Related branches

lp:~michael.nelson/ubuntu-webcatalog/1267731-import-sca-apps-error
Martin Albisetti (community): Approve
Diff: 254 lines (+191/-3)
5 files modified
src/webcatalog/forms.py (+1/-1)
src/webcatalog/management/commands/import_sca_apps.py (+6/-1)
src/webcatalog/migrations/0030_application_debtags_to_textfield.py (+174/-0)
src/webcatalog/models/applications.py (+1/-1)
src/webcatalog/tests/test_commands.py (+9/-0)
Revision history for this message
Michael Nelson (michael.nelson) wrote :

I ran a local import using the production sca data, and the actual error (which we should handle) is that the deb_tags field is longer than expected for an app, due to every whitelist country being selected: https://pastebin.canonical.com/102770/

Haw Loeung (hloeung)
tags: added: canonical-webops-uwc
Michael Nelson (michael.nelson)
Changed in ubuntu-webcatalog:
assignee: nobody → Michael Nelson (michael.nelson)
Ubuntu One Auto Pilot (otto-pilot)
Changed in ubuntu-webcatalog:
status: Confirmed → Fix Committed
Michael Nelson (michael.nelson)
Changed in ubuntu-webcatalog:
status: Fix Committed → Fix Released
Revision history for this message
Michael Nelson (michael.nelson) wrote :

The app causing the import error is now available [1], and the server log is clear.

That said, there are some issues with the display of this particular app (screenshot not displayed - created bug 1269295, and the hardware requirements result in a list of None down the side-bar - created bug 1269298).

[1] https://apps.ubuntu.com/cat/applications/sca/

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.