[browser] bookmarks don't support folders
Bug #1259247 reported by
Adnane Belmadiaf
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Translations |
New
|
Undecided
|
Unassigned | ||
| Ubuntu UX |
Fix Released
|
Medium
|
James Mulholland | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Arthur Mello | ||
Bug Description
User should be able to:
- Assign a bookmark to a folder when it is created
- View bookmarks folder in the new tab screen
- drag & drop bookmarks into folders in landscape mode
UX:
https:/
[UX Comment]
Implemented and working:
- Assign a bookmark to a folder when it is created
- View bookmarks folder in the new tab screen
Not yet implemented:
- drag & drop bookmarks into folders in landscape mode
https:/
Related branches
lp:~artmello/webbrowser-app/webbrowser-app-bookmark_folders
- Olivier Tilloy: Approve
- PS Jenkins bot: Approve (continuous-integration)
- Bill Filler (community): Needs Fixing
-
Diff: 2658 lines (+1979/-70)27 files modifiedsrc/app/webbrowser/AddressBar.qml (+7/-0)
src/app/webbrowser/BookmarkOptions.qml (+166/-0)
src/app/webbrowser/BookmarksFolderListView.qml (+157/-0)
src/app/webbrowser/Browser.qml (+64/-4)
src/app/webbrowser/CMakeLists.txt (+2/-0)
src/app/webbrowser/Chrome.qml (+2/-0)
src/app/webbrowser/NewTabView.qml (+27/-9)
src/app/webbrowser/UrlsList.qml (+2/-2)
src/app/webbrowser/bookmarks-folder-model.cpp (+84/-0)
src/app/webbrowser/bookmarks-folder-model.h (+60/-0)
src/app/webbrowser/bookmarks-folderlist-model.cpp (+217/-0)
src/app/webbrowser/bookmarks-folderlist-model.h (+79/-0)
src/app/webbrowser/bookmarks-model.cpp (+164/-8)
src/app/webbrowser/bookmarks-model.h (+15/-3)
src/app/webbrowser/webbrowser-app.cpp (+2/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+52/-0)
tests/autopilot/webbrowser_app/tests/test_addressbar_bookmark.py (+3/-0)
tests/autopilot/webbrowser_app/tests/test_bookmark_options.py (+243/-0)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+6/-2)
tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+150/-22)
tests/autopilot/webbrowser_app/tests/test_suggestions.py (+2/-2)
tests/unittests/CMakeLists.txt (+2/-0)
tests/unittests/bookmarks-folder-model/CMakeLists.txt (+6/-0)
tests/unittests/bookmarks-folder-model/tst_BookmarksFolderModelTests.cpp (+123/-0)
tests/unittests/bookmarks-folderlist-model/CMakeLists.txt (+6/-0)
tests/unittests/bookmarks-folderlist-model/tst_BookmarksFolderListModelTests.cpp (+269/-0)
tests/unittests/bookmarks-model/tst_BookmarksModelTests.cpp (+69/-18)
| Changed in webbrowser-app: | |
| status: | New → Confirmed |
| Changed in ubuntu-ux: | |
| assignee: | nobody → Olga Kemmet (olga-kemmet) |
| assignee: | Olga Kemmet (olga-kemmet) → Giorgio Venturi (giorgio-venturi) |
Revision history for this message
| Giorgio Venturi (giorgio-venturi-deactivatedaccount) wrote | #1 |
| Changed in ubuntu-ux: | |
| status: | New → Won't Fix |
| Changed in webbrowser-app: | |
| importance: | Undecided → Wishlist |
| Changed in ubuntu-ux: | |
| status: | Won't Fix → Fix Committed |
| importance: | Undecided → Medium |
| description: | updated |
| summary: |
- The browser favorites doesn't support folders + [browser] favorites doesn't support folders |
| summary: |
- [browser] favorites doesn't support folders + [browser] bookmarks doesn't support folders |
| summary: |
- [browser] bookmarks doesn't support folders + [browser] bookmarks don't support folders |
| tags: | added: ota-2 |
| Changed in webbrowser-app: | |
| importance: | Wishlist → Medium |
| tags: | added: design-gap |
| Changed in ubuntu-ux: | |
| assignee: | Giorgio Venturi (giorgio-venturi) → James Mulholland (jamesjosephmulholland) |
| Changed in webbrowser-app: | |
| status: | Confirmed → Invalid |
| Changed in webbrowser-app (Ubuntu): | |
| importance: | Undecided → High |
| assignee: | nobody → Arthur Mello (artmello) |
| status: | New → In Progress |
| no longer affects: | webbrowser-app |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| description: | updated |
| description: | updated |
| description: | updated |
Revision history for this message
| James Mulholland (jamesmulholland) wrote | #3 |
| Changed in ubuntu-ux: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This feature will not be supported in the MVP