unity-api fails to build against Qt 5.2

Bug #1258057 reported by Timo Jyrinki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity API
Invalid
Critical
Unassigned
qtdeclarative-opensource-src (Ubuntu)
Fix Released
Critical
Timo Jyrinki

Bug Description

unity-api fails to build against Qt 5.2 (fails tests) on i386 and armhf:
https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-beta2/+build/5303137
https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-beta2/+build/5303136

amd64 succeeded.

The solution should be so that the source builds both against Qt 5.0.2 and 5.2, possibly via #ifdef:s or such.

To reproduce:

apt-add-repository ppa:canonical-qt5-edgers/qt5-beta2
apt-get update
apt-get dist-upgrade
bzr branch lp:unity-api
cd unity-api
bzr bd
(or PPA upload)

Tags: qt5.2
description: updated
tags: added: qt5.2
description: updated
Revision history for this message
Michael Zanetti (mzanetti) wrote :

This is a failing test because of crashes in V4. Must be an issue inside qtdeclarative as the code seems perfectly fine (and works on amd64)

Revision history for this message
Michał Sawicz (saviq) wrote :

Potential duplicate: bug #1259234 - with a potential fix https://bugreports.qt-project.org/browse/QTBUG-33658 - testing right now.

Revision history for this message
Michał Sawicz (saviq) wrote :

This failure indeed goes away with https://qt.gitorious.org/qt/qtdeclarative/commit/3c9c35b648e32082b30786fe71d4db33ffe2b5a6.patch

Not the other bug, though, I'm afraid :/

Changed in unity-api:
status: New → In Progress
assignee: nobody → Michał Sawicz (saviq)
Revision history for this message
Michał Sawicz (saviq) wrote :

Timo, can you please try and integrate the above and confirm the unity-api FTBFS goes away?

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Ok, sounds good (/better), integrating and testing.

Revision history for this message
Michał Sawicz (saviq) wrote :

Unfortunately didn't help, here's a symbolic trace:

http://paste.ubuntu.com/6551990/

Revision history for this message
Michał Sawicz (saviq) wrote :
Michał Sawicz (saviq)
Changed in unity-api:
assignee: Michał Sawicz (saviq) → Daniel d'Andrada (dandrader)
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

With qt5 stable branch (Qt 5.2.1) testLauncher doesn't crash but testApplication fails (but "cleanly", without crashing)

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

cherry-picked all commits from stable but not in release on top of release. Crash stops happening from commit 5105d5ceb85aab4f1b24fefcb39e525f5cdc8300 (Speedup JS instanceof operator) onwards. But cherry-picking that commit alone on top of v5.2.0 (release) doesn't solve it. Thus it's not such a straigh-forward pick.

It seems that V4 is under frank development from the number of commits changing its code in the "stable vs. release" diff. Which makes me wonder if it makes sense to cherry-pick stuff onto v5.2.0 as opposed to simply waiting for that code to really stabilize (i.e.. trying the latest stable)

Changed in unity-api:
status: In Progress → Triaged
Changed in unity-api:
status: Triaged → In Progress
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Bug reported on the testApplication failure with the stable branch (Qt 5.2.1) of qtdeclarative:
https://bugreports.qt-project.org/browse/QTBUG-35721

Revision history for this message
Michał Sawicz (saviq) wrote :

The actual commit id in qtdeclarative branch is 8e25658011699596996e80d3d08f17ef2efa0634

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> The actual commit id in qtdeclarative branch is 8e25658011699596996e80d3d08f17ef2efa0634

That commit came into qtdeclarative's stable branch *after* I did my git bisect run.

Revision history for this message
Michał Sawicz (saviq) wrote :

Timo is getting a snapshot of qtdeclarative/stable into the PPA now, so this should be fixed then.

Changed in unity-api:
assignee: Daniel d'Andrada (dandrader) → nobody
assignee: nobody → Timo Jyrinki (timo-jyrinki)
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Yeah, the "enum in a singleton" bug (https://bugreports.qt-project.org/browse/QTBUG-35721) that caused testApplication to fail was fixed in stable branch

Changed in qtdeclarative-opensource-src (Ubuntu):
status: New → Fix Committed
assignee: nobody → Timo Jyrinki (timo-jyrinki)
importance: Undecided → Critical
Changed in unity-api:
assignee: Timo Jyrinki (timo-jyrinki) → nobody
status: In Progress → Invalid
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Confirming unity-api now successfully builds in qt5-beta2 PPA!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtdeclarative-opensource-src - 5.2.1-3ubuntu10

---------------
qtdeclarative-opensource-src (5.2.1-3ubuntu10) trusty; urgency=medium

  * debian/patches/Fix-crash-when-appending-arrays-to-sub-models-in-lis.patch
    - Backport from upstream https://codereview.qt-project.org/#change,80934
      (LP: #1291602)
 -- Timo Jyrinki <email address hidden> Fri, 14 Mar 2014 09:37:56 +0000

Changed in qtdeclarative-opensource-src (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.