log crashes when passed non-string
Bug #1255933 reported by
Stuart Bishop
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Charm Helpers |
Fix Released
|
Wishlist
|
Jorge Niedbalski | ||
Bug Description
log crashes if its first argument is not a string.
Lets log the repr() if the message is not isinstance(message, basestring) to make it friendlier as a debugging tool.
Related branches
lp:~niedbalski/charm-helpers/fix-lp1255933
- Felipe Reyes (community): Approve
- charmers: Pending requested
-
Diff: 42 lines (+8/-1)3 files modifiedcharmhelpers/core/hookenv.py (+2/-0)
charmhelpers/core/host.py (+1/-1)
tests/core/test_hookenv.py (+5/-0)
| Changed in charm-helpers: | |
| importance: | Undecided → Wishlist |
Revision history for this message
| Jorge Niedbalski (niedbalski) wrote | #1 |
| Changed in charm-helpers: | |
| status: | New → Fix Committed |
| assignee: | nobody → Jorge Niedbalski (niedbalski) |
| tags: | added: cts |
| Changed in charm-helpers: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Linked the fix. Thanks for pointing this.