fwts: conditionally don't run Ubuntu specific code
Bug #1246653 reported by
Colin Ian King
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Firmware Test Suite |
Fix Released
|
Low
|
Colin Ian King | ||
Bug Description
There are some Ubuntu specific items of code in fwts, we should add an option to conditionally compile these in and update the documentation to explain how to turn this on or off.
Related branches
Revision history for this message
| Colin Ian King (colin-king) wrote | #1 |
| summary: |
- fwts: conditionally compile in Ubuntu specific code + fwts: conditionally don't run Ubuntu specific code |
Revision history for this message
| Colin Ian King (colin-king) wrote | #2 |
| Changed in fwts: | |
| status: | New → In Progress |
| importance: | Undecided → Low |
| assignee: | nobody → Colin King (colin-king) |
| Changed in fwts: | |
| status: | In Progress → Fix Committed |
| milestone: | none → 14.01.00 |
Revision history for this message
| Colin Ian King (colin-king) wrote | #3 |
| Changed in fwts: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
After looking at this a little deeper, conditionally compiling code in/out makes testing more complex and we don't have the resources to pursue this. Instead, I am proposing toning down the Ubuntu specific messages/tests in fwts so they do not reference Ubuntu as much and also skip any Ubuntu specific tests w/o mentioning Ubuntu where possible.
Some fixes have already addressed this issue, for example, bug 1261760 that has removed all the Launchpad specific tagging.