should offer a commandline option to override the user agent in webapp mode
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
webbrowser-app |
Fix Released
|
High
|
Alexandre Abreu | ||
unity-webapps-qml (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Alexandre Abreu |
Bug Description
instead of having to add each and every url pattern to ua-overrides.js, it would be nice if webbrowser-app could offer a commandline option to override the user agent string when in webapp mode ...
while the override file is nice and all, it will not help for released images since we can not retroactively add overrides to the file, so webapps someone writes will only work from a specific release on if the site they use needs a specific UA string. while getting the override into the file eventually makes sense and should be the default, being able to override it in the Exec call of the .desktop file would make it possible to run the specific webapp in releases that dont ship the matching pattern in the .js file yet.
while we have possibilities to override the setting with a qml wrapper like in http://
so please consider adding something like a --ua-override= commandline option for the webapp mode.
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Olivier Tilloy: Approve
-
Diff: 137 lines (+36/-13)5 files modifiedsrc/app/webcontainer/WebApp.qml (+3/-1)
src/app/webcontainer/WebViewImplOxide.qml (+7/-1)
src/app/webcontainer/WebViewImplWebkit.qml (+5/-0)
src/app/webcontainer/WebappContainerWebview.qml (+18/-8)
src/app/webcontainer/webapp-container.cpp (+3/-3)
- PS Jenkins bot (community): Approve (continuous-integration)
- WebApps: Pending requested
-
Diff: 696 lines (+170/-87)21 files modifiedsrc/Ubuntu/UnityWebApps/UnityWebApps.js (+14/-3)
src/Ubuntu/UnityWebApps/UnityWebApps.qml (+40/-43)
src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js (+1/-1)
src/Ubuntu/UnityWebApps/plugin/unity-webapps-app-manifest-parser.cpp (+7/-0)
src/Ubuntu/UnityWebApps/plugin/unity-webapps-app-manifest-parser.h (+2/-0)
src/Ubuntu/UnityWebApps/plugin/unity-webapps-app-model.cpp (+22/-0)
src/Ubuntu/UnityWebApps/plugin/unity-webapps-app-model.h (+9/-1)
tests/integration/autopilot/html/test_webapps_api_injected.html (+17/-0)
tests/integration/autopilot/html/test_webapps_hud.html (+2/-2)
tests/integration/autopilot/qml/FullWebViewApp.qml (+2/-1)
tests/integration/autopilot/unity_webapps_qml/tests/__init__.py (+2/-1)
tests/integration/autopilot/unity_webapps_qml/tests/test_hud.py (+4/-5)
tests/integration/autopilot/unity_webapps_qml/tests/test_injectedOnWebapp.py (+13/-13)
tests/unit/test_plugin/data/manifests/valid-with-ua-override.json (+15/-0)
tests/unit/test_plugin/test_plugin.pro (+2/-1)
tests/unit/test_plugin/tst_manifestParser.cpp (+8/-0)
tests/unit/test_plugin/tst_manifestParser.h (+1/-1)
tests/unit/test_qml/tst_cleanup.qml (+4/-5)
tests/unit/test_qml/tst_dispatch.qml (+1/-5)
tests/unit/test_qml/tst_init.qml (+1/-5)
tools/qml-launcher/qml-launcher.cpp (+3/-0)
Changed in webbrowser-app: | |
assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
Changed in webbrowser-app (Ubuntu): | |
assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
importance: | Undecided → High |
tags: | added: webapps-hotlist |
Changed in webbrowser-app: | |
status: | Confirmed → In Progress |
Changed in webbrowser-app (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in unity-webapps-qml (Ubuntu): | |
status: | New → In Progress |
Changed in webbrowser-app: | |
status: | In Progress → Fix Released |
Status changed to 'Confirmed' because the bug affects multiple users.